Skip to content

🤖 fix: add NON_INTERACTIVE_ENV_VARS to SSHRuntime.exec() #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2025
Merged

🤖 fix: add NON_INTERACTIVE_ENV_VARS to SSHRuntime.exec() #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/node/runtime/SSHRuntime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { RuntimeError as RuntimeErrorClass } from "./Runtime";
import { EXIT_CODE_ABORTED, EXIT_CODE_TIMEOUT } from "@/common/constants/exitCodes";
import { log } from "@/node/services/log";
import { checkInitHookExists, createLineBufferedLoggers, getInitHookEnv } from "./initHook";
import { NON_INTERACTIVE_ENV_VARS } from "@/common/constants/env";
import { streamProcessToLogger } from "./streamProcess";
import { expandTildeForSSH, cdCommandForSSH } from "./tildeExpansion";
import { getProjectName } from "@/node/utils/runtime/helpers";
Expand Down Expand Up @@ -106,11 +107,10 @@ export class SSHRuntime implements Runtime {
// Add cd command if cwd is specified
parts.push(cdCommandForSSH(options.cwd));

// Add environment variable exports
if (options.env) {
for (const [key, value] of Object.entries(options.env)) {
parts.push(`export ${key}=${shescape.quote(value)}`);
}
// Add environment variable exports (user env first, then non-interactive overrides)
const envVars = { ...options.env, ...NON_INTERACTIVE_ENV_VARS };
for (const [key, value] of Object.entries(envVars)) {
parts.push(`export ${key}=${shescape.quote(value)}`);
}

// Add the actual command
Expand Down
15 changes: 15 additions & 0 deletions tests/runtime/runtime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,21 @@ describeIntegration("Runtime integration tests", () => {
expect(result.stdout.trim()).toBe("test-value");
});

test.concurrent("sets NON_INTERACTIVE_ENV_VARS to prevent prompts", async () => {
const runtime = createRuntime();
await using workspace = await TestWorkspace.create(runtime, type);

// Verify GIT_TERMINAL_PROMPT is set to 0 (prevents credential prompts)
const result = await execBuffered(
runtime,
'echo "GIT_TERMINAL_PROMPT=$GIT_TERMINAL_PROMPT GIT_EDITOR=$GIT_EDITOR"',
{ cwd: workspace.path, timeout: 30 }
);

expect(result.stdout).toContain("GIT_TERMINAL_PROMPT=0");
expect(result.stdout).toContain("GIT_EDITOR=true");
});

test.concurrent("handles empty output", async () => {
const runtime = createRuntime();
await using workspace = await TestWorkspace.create(runtime, type);
Expand Down