🤖 ci: add robust Electron E2E tests for regression prevention #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ammar-agent
force-pushed
the
electron-e2e-tests
branch
2 times, most recently
from
7219d69 to
bed9e1c
Compare
Add E2E tests targeting recent regression patterns: - Window lifecycle: startup, workspace loading, rapid navigation, IPC stability - Streaming behavior: modal interruption, mode switching, error handling - Persistence: chat history survives reload and settings navigation Also: - Add mock error scenarios (rate limit, server error, network error) - Fix captureStreamTimeline to handle stream-error events - Run E2E tests on macOS (depot runner) for window lifecycle coverage - Fix macOS CI compatibility (grep -oE, conditional install-deps) _Generated with mux_
ammar-agent
force-pushed
the
electron-e2e-tests
branch
from
bed9e1c to
9e0d724
Compare
ammario
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive E2E tests covering window lifecycle, IPC robustness, streaming edge cases, persistence, and error display. These tests target recent regression patterns.
Recent Regressions Addressed
MockBrowserWindow.isDestroyed()(#863)ipcRobustness.spec.ts- concurrent IPC operationswindowLifecycle.spec.ts- rapid IPC calls teststreamEdgeCases.spec.ts+errorDisplay.spec.tsNew Test Files (26 tests total)
Infrastructure Changes
stream-errorevents (previously onlystream-end)CI Configuration
Generated with
mux