SSE decoder fix in packages/ssestream/ssestream.go #3
Open
kasyap1234 wants to merge 2 commits into
Open
Conversation
Introduce hasData to track if any data was collected since the last empty line. Dispatch events on blank lines only when data exists; otherwise reset state without emitting an event.
Author
|
@kylecarbs requesting you to review this ,as this is linked to this coder/coder#26469 |
Member
|
(linked to coder/coder#26469) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the SSE decoder fix in packages/ssestream/ssestream.go so empty/comment-only blocks no longer dispatch empty events.
Added tests in packages/ssestream/ssestream_test.go covering:
Validation:
go test ./packages/ssestream passes