feat(vscode-desktop): pre-install remote extensions - #1094
Conversation
DevelopmentCats
left a comment
There was a problem hiding this comment.
There are a couple things regarding the scorecard that can be addressed in a later PR but otherwiser this looks and works well
|
How do we ensure we are not installing an incompatible extension, since a user may be connecting from an older VS Code release that would download its own server? It's still a good workaround, though. Let's add this to https://github.com/coder/coder/tree/main/dogfood/coder for dogfooding |
|
Also @Edd88-pixel should #208 now be closed? |
|
Good point. The bootstrap server is isolated, so an older VS Code client can still install its own matching server. The part we don't currently guarantee is extension compatibility, since extensions are initially resolved using the stable bootstrap server. Dogfooding this makes sense. We can follow up on that and test the behavior with older VS Code versions. |
Why
The VS Code Desktop wrapper could not pre-install remote extensions before the first desktop connection . This advances the extension pre-installation portion of #207 by bootstrapping the official stable remote server and delegating installation to
vscode-desktop-core.Changes
extensionsinput while preserving the existing empty defaultvscode-desktop-corev1.2.0 and pass the remote CLI, config, and extension pathsValidation
bun test registry/coder/modules/vscode-desktop/main.test.ts— 9 passed, 0 failedterraform validate -no-color— passedDescription
Adds opt-in remote extension pre-installation to the VS Code Desktop module.
Type of Change
Module Information
Path:
registry/coder/modules/vscode-desktopNew version:
v1.3.0Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun fmt)Related Issues
Related to #207