Skip to content

Add arbitrary mux server command argument parsing#738

Merged
DevelopmentCats merged 3 commits into
mainfrom
mike/mux-server-command-parsing
Feb 25, 2026
Merged

Add arbitrary mux server command argument parsing#738
DevelopmentCats merged 3 commits into
mainfrom
mike/mux-server-command-parsing

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a new additional_arguments module variable to pass extra arguments to mux server
  • parse additional_arguments in run.sh with quoted-group support so values like paths with spaces are preserved
  • keep existing add-project behavior while allowing additional arbitrary flags
  • add Terraform and Bun tests covering additional_arguments behavior
  • document the new option in the module README and bump example version references to 1.2.0

Why

The module previously only supported the add-project flag. This change lets users pass additional mux server arguments without waiting for new module variables.

Validation

  • shellcheck --severity=warning --format=gcc registry/coder/modules/mux/run.sh
  • terraform -chdir=registry/coder/modules/mux test -verbose
  • bun test registry/coder/modules/mux/main.test.ts

Breaking changes

None.


Generated with Mux (exec agent) using GPT-5.

Comment thread registry/coder/modules/mux/main.tf Outdated
@ibetitsmike

Copy link
Copy Markdown
Contributor Author

Addressed review feedback: renamed the new mux argument field to "additional_arguments" (consistent naming with other modules), and updated script wiring, tests, and README examples.

@matifali matifali left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DevelopmentCats
DevelopmentCats enabled auto-merge (squash) February 25, 2026 18:14
@DevelopmentCats
DevelopmentCats merged commit 94e41d3 into main Feb 25, 2026
4 checks passed
@DevelopmentCats
DevelopmentCats deleted the mike/mux-server-command-parsing branch February 25, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants