Fix false "setting changed" notifications on remote connect #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielleMaywood
approved these changes
Dec 15, 2025
Collaborator
DanielleMaywood
left a comment
DanielleMaywood
left a comment
There was a problem hiding this comment.
Approving although I'd definitely prefer we find a solution for the as unknown as pattern. As they're in tests and not production code this is a non-blocking comment
The watchSettings function was using affectsConfiguration() which can return true even when values haven't changed (e.g., during Remote SSH connection setup). Now compares actual values using getter functions that properly resolve defaults. Also: - Add coder.headerCommand to watched settings - Show single notification listing all changed settings
EhabY
force-pushed
the
fix-notify-setting-change-on-connect
branch
from
e57b14c to
103be3f
Compare
EhabY
force-pushed
the
fix-notify-setting-change-on-connect
branch
from
103be3f to
e5d706d
Compare
DanielleMaywood
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
affectsConfiguration()getGlobalFlagsRaw,getSshFlags,getLogDir,getHeaderCommand) to properly resolve defaultscoder.headerCommandto watched settingsCloses #681