[desktop] 🤖 fix: allow approved remote microphone access - #4108
Open
coadler wants to merge 2 commits into
Open
Conversation
Require native consent for audio-only requests from active remote app windows. Cancel stale permission requests and preserve remote session isolation. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `high` • Cost: `$9.10`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=high costs=9.10 -->
Collaborator
Author
|
@codex review |
This comment has been minimized.
This comment has been minimized.
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Require focus before a request, then recheck connection and document identity after approval. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `high` • Cost: `$9.10`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=high costs=9.10 -->
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow user-approved microphone access from active remote Electron app windows.
Background
This follows #4101, which now exists on
main. Voice input continues to use browsergetUserMedia({ audio: true }).Remote pages receive no privileged local APIs.
Risks
Native microphone access depends on OS privacy settings. Permission denial does not persist in Xum, so users can retry.
Generated with
xum• Model:openai:gpt-6-astra• Thinking:high• Cost:$9.10