refactor: remove the 'RevisionCheck' and 'GitHubSecret' types

[xcoulon]

not used anymore after merging codeready-toolchain/host-operator#1281 and codeready-toolchain/member-operator#755

Updated CRD is available in codeready-toolchain/host-operator#1287

see also

• refactor: remove the VersionCheckManager toolchain-common#539
• refactor: remove the RevisionCheck conditions member-operator#760
• build: update 'api' and 'common' deps registration-service#613
• build: update 'api' and 'common' deps toolchain-e2e#1302

Signed-off-by: Xavier Coulon xcoulon@redhat.com

Summary by CodeRabbit

• API Changes
  • Removed deprecated GitHub secret configuration fields from status configuration.
  • Removed revision check status data from host, registration service, and member operator statuses.
  • Removed the related GitHub secret and revision check API types.
  • Replaced revision-check deployment reasons with clearer deployment readiness states.
  • Marked host operator status as deprecated; metrics are recommended instead.

[coderabbitai]

Walkthrough

The API v1alpha1 schema removes GitHubSecret and RevisionCheck, replaces deployment reason constants, deprecates HostOperatorStatus, synchronizes generated deepcopy/OpenAPI files, and updates the API reference.

Changes

API schema cleanup

Layer / File(s)	Summary
API contract updates api/v1alpha1/*_types.go	Public configuration and status types remove obsolete fields and GitHubSecret/RevisionCheck definitions; deployment reason constants are updated and HostOperatorStatus is deprecated.
Generated schema synchronization api/v1alpha1/zz_generated.*.go	Generated deepcopy and OpenAPI definitions remove handling and registration for the deleted types and fields.
API reference synchronization api/v1alpha1/docs/apiref.adoc	Reference documentation removes obsolete schemas and fields and records the HostOperatorStatus deprecation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: refactoring, documentation

Suggested reviewers: alexeykazakov, matousjobanek

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	⚠️ Warning	The description is missing the required template sections and the requested yes/no checks, so it is largely incomplete.	Add a ## Description section plus the ## Checks questions with yes/no answers, and include any required PR links if other projects changed.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly matches the main change: removing the RevisionCheck and GitHubSecret API types.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Fix failing CI checks

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[MatousJobanek]

actually, I'm missing the PRs with the generated/updated CRDs

never mind, just saw it 🤦‍♂️
can you please add links to the description of the PR?

[xcoulon]

actually, I'm missing the PRs with the generated/updated CRDs

never mind, just saw it 🤦‍♂️ can you please add links to the description of the PR?

ah right, I added a link to this PR in the other ones (common, etc.), but let me do it here as well