Navbar and Footer snippets to not support multisite

[vsalvino]

Describe the bug
All navbars and footers are rendered on the page, regardless of the site. We should be specifying the site from the request when querying navbars and footers.

coderedcms/coderedcms/templatetags/coderedcms_tags.py

Lines 81 to 87 in a3ab4de

	@register.simple_tag
	def get_navbars():
	return Navbar.objects.all()
	@register.simple_tag
	def get_footers():
	return Footer.objects.all()

To Reproduce
Steps to reproduce the behavior:

1. Create multiple sites / root pages
2. Create a different navbar or footer snippet in each site.
3. When browsing each specific site, navbars/footers from both sites are rendered.

Expected behavior
Only navbars and footers for a specific site should render when browsing that site.

Additional context
See community issue #200

[carlosmonari]

Hello there,

Before everything, thanks for the CodeRed CMS tool.
It is incredibly simple to use.
I wrote a possible solution for this problem.
Is it possible put this solution in CodeRed CMS ?

The solution is:

in file wagtailsettings_models.py (add after field favicon in class LayoutSettings )

navbar_name = models.CharField(
    blank=True,
    max_length=50,
    verbose_name=_('Navbar name'),
    help_text=_('It is necessary to associate when you create a Navigation Bar fragments.'),
)

and add panels

before

panels = [
    MultiFieldPanel(
        [
            ImageChooserPanel('logo'),
            ImageChooserPanel('favicon'),
        ],
        heading=_('Branding')
    ),
    MultiFieldPanel(
        [
            FieldPanel('navbar_color_scheme'),
            FieldPanel('navbar_class'),

after

panels = [
    MultiFieldPanel(
        [
            ImageChooserPanel('logo'),
            ImageChooserPanel('favicon'),
        ],
        heading=_('Branding')
    ),
    MultiFieldPanel(
        [
            FieldPanel('navbar_name'),
            FieldPanel('navbar_color_scheme'),
            FieldPanel('navbar_class'),

in file snippet_models.py (add after field name in class Navbar )

included

from coderedcms.models.wagtailsettings_models import LayoutSettings

layoutsetting = models.ForeignKey(
    LayoutSettings,
    null=True,
    blank=True,
    on_delete=models.SET_NULL,
    related_name='+',
    verbose_name=_('Layout Page'),
    help_text=_('The Layout page users to determinate a site owner Navigation Bar Manu.'),
)

and increase panels

before

panels = [
    FieldPanel('name'),
    MultiFieldPanel(
        [
            FieldPanel('custom_css_class'),
            FieldPanel('custom_id'),
        ],

after

panels = [
    FieldPanel('name'),
    FieldPanel('layoutsetting'),
    MultiFieldPanel(
        [
            FieldPanel('custom_css_class'),
            FieldPanel('custom_id'),
        ],

in file coderedcms_tags.py:

Inluded LayoutSettings in this line

from coderedcms.models import Footer, Navbar, LayoutSettings

and include Site in this line

from wagtail.core.models import Collection, Site

and change get_navbars

before

@register.simple_tag
def get_navbars():
	return Navbar.objects.all()

after

@register.simple_tag
def get_navbars(request):
	curr_url = request.site.hostname
	site = Site.objects.get(hostname=curr_url)
	layout = LayoutSettings.objects.get(site_id=site)
	return Navbar.objects.filter(layoutsetting_id=layout.id)

in file navbar.html

before

<div class="collapse navbar-collapse" id="navbar">
  {% get_navbars as navbars %}
  {% for navbar in navbars %}				

after

<div class="collapse navbar-collapse" id="navbar">
  {% get_navbars request as navbars %}
  {% for navbar in navbars %}				

and finall

python manage.py makemigrations 
python manage.py migrate

See the screens for solution:

and the source code :

coderedcms.zip

Sorry, my english is very poor.
Tchau!

[vsalvino]

Thanks for the legwork @carlosmonari !

I think you may have gone above and beyond what is necessary. The only changed needed would probably be in get_navbars(), something like this:

before

@register.simple_tag
def get_navbars():
	return Navbar.objects.all()

after

@register.simple_tag(takes_context=True)
def get_navbars(context):
	return Navbar.objects.filter(site=context['request'].site)

Since navbars are Snippets they are already associated with a Site by Wagtail. If you get it working, please submit your change as a Pull Request and we can review and merge it in.

[carlosmonari]

Hi Vince Salvino,

You considered a ForeignKey site in Object NavBar, but in database doesn´t have this relation.

return Navbar.objects.filter(site=context['request'].site)

I previously thought of this, but in my proposal i associate Navbar with LayoutSettings, because the template exists a association with site and other NavBar's properties.

I thought be the better data model to put this property.

When we have change LayoutSetting's in site, we will have a new NavBar too.

look at the attached picture with the actual model and a error when we have implemented just only your suggestion.

@register.simple_tag(takes_context=True)
def get_navbars(context):
	return Navbar.objects.filter(site=context['request'].site)

Request Method:	GET
http://localhost:8000/
2.2.3
FieldError
Cannot resolve keyword 'site' into field. Choices are: custom_css_class, custom_id, id, menu_items, name

[vsalvino]

@carlosmonari ah yes, my bad, I was thinking of the Settings which are bound to a specific site. The snippets are not. In that case, I think your solution would work. Can you please make a pull request so we can test and review? Thanks!

[vsalvino]

Referencing pull request #216