Merged
Conversation
corysutyak
approved these changes
Apr 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A page preview functions similar to the "latest pages" block, but is limited to one single page. Adding templates for: a basic page preview (default), bootstrap card style, and a form template that renders a form page as an inline form.
This also got me thinking about the different between content_blocks and html_blocks. I believe the definitions should be:
That being said, I moved the PageListBlock and the new PagePreviewBlock into html_blocks as they are simply page choosers. This also enables them to be used inside of modals, carousels, etc. which is beneficial for the purpose of putting a form preview in a modal.
Also making sure all card templates render images in the same ratio/resolution for consistency.