Skip to content

Fix bug caused by child having multiple terms set under the index order by classifier #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsalvino merged 3 commits into from
Jan 10, 2024
Merged

Fix bug caused by child having multiple terms set under the index order by classifier #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f570a91
Fix bug caused by child having multiple terms set under the index sor…
jlchilders11 Jan 9, 2024
91577ac
Fix spelling error
jlchilders11 Jan 9, 2024
b9a047d
Alter docs python version
jlchilders11 Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ stages:
- task: UsePythonVersion@0
displayName: 'Use Python version'
inputs:
versionSpec: '3.12'
versionSpec: '3.11'
architecture: 'x64'

- script: python -m pip install -r requirements-ci.txt
Expand Down
2 changes: 1 addition & 1 deletion coderedcms/models/page_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ def get_index_children(self):
classifier=self.index_order_by_classifier,
# Reverse ManyToMany of `coderedpage.classifier_terms`.
coderedpage=models.OuterRef("pk"),
)
)[:1]
Comment thread
vsalvino marked this conversation as resolved.
query = query.annotate(
term_sort_order=models.Subquery(terms.values("sort_order"))
)
Expand Down
2 changes: 1 addition & 1 deletion docs/releases/v3.0.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ v3.0.2 release notes
Bug fixes
---------

* Fix site search: when searching by specific page models (``search_filterable=True``) on MySQL databases, no search results would be returned. We have applied a workaround to this bug in Wagtail, with one small caveat: for example when filtering by a model ``WebPage``, the search results on SQLite and Postgres will return results for ``WebPage`` and anything inherting from ``WebPage``. On MySQL, it will ONLY return ``WebPage`` results. *However, the bug still persists in the Wagtail Admin search and will need to be fixed in a future version of Wagtail.*
* Fix site search: when searching by specific page models (``search_filterable=True``) on MySQL databases, no search results would be returned. We have applied a workaround to this bug in Wagtail, with one small caveat: for example when filtering by a model ``WebPage``, the search results on SQLite and Postgres will return results for ``WebPage`` and anything inheriting from ``WebPage``. On MySQL, it will ONLY return ``WebPage`` results. *However, the bug still persists in the Wagtail Admin search and will need to be fixed in a future version of Wagtail.*


Thank you!
Expand Down