fix(lsp): restore work-done progress - #293
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Language servers such as rust-analyzer only emit work-done progress after the client advertises support and acknowledges
window/workDoneProgress/create. Red advertised progress as unsupported and rejected creation requests, so the bundled Fidget overlay loaded successfully but never received anything to display.What changed
window.workDoneProgressin Red's LSP initialization capabilities.begin/report/endnotifications for both string and numeric tokens.How to Test
cargo test -p red --lib work_done_progress_is_negotiated_created_and_forwarded -- --nocapture. Expect the complete progress handshake and both token variants to pass.cargo test -p red --lib fidget_. Expect the bundled Fidget overlay rendering, numeric-token handling, and timer-cleanup tests to pass.cargo run -- path/to/src/main.rs. During rust-analyzer indexing, expect the Fidget progress overlay to show the active task and clear after completion.Validated with
cargo clippy --all-targets --all-features -- -D warningsand 2,974 passing package tests. The package run excluded the unrelated pre-existing Neo-tree testneotree_renders_deep_mostly_clean_workspaces_within_the_instruction_budget, whose stale 200-row expectation conflicts with the newer unbounded-tree implementation.