perf(picker): accelerate large workspace file searches - #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The file picker rescored every workspace file after every keystroke. In large repositories, broad path prefixes keep thousands of candidates alive and make typing noticeably sluggish.
What changed
Median filtering time for the
codex-rs/core/srcquery in an optimized build:How to Test
cargo test -p red --lib ui:: -- --test-threads=1; all 345 UI tests should pass, including the large-list ordering and query-broadening regressions. The manual benchmark remains ignored during normal runs.RED_FILE_PICKER_BENCH_ROOT=/path/to/large/workspace cargo test --release -p red --lib file_picker_large_workspace_performance -- --ignored --nocapture; the benchmark should report five-sample medians for discovery, installation, keystrokes, filtering, and drawing. Omit the environment variable to exercise the portable 12,000-file fixture.Also verified with
cargo clippy --all-targets --all-features -- -D warnings.