fix(notifications): make routine errors non-intrusive - #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unknown Ex commands are immediate feedback about input the user just submitted. Treating them as acknowledgment-required errors leaves a typo active indefinitely, lets it resurface after newer messages, and makes the bottom-line attention badge imply an unresolved problem.
This change keeps unknown commands styled as errors and retained in message history, while classifying them as quiet, transient feedback. Attention overrides now select the matching foreground lifetime, so quiet and missed-only notices expire while acknowledgment-required conditions remain active.
How to Test
:not-a-command. Confirm the red error appears without aneeds attentionor:messagesbadge, disappears after the transient display period, and remains available in message history.:write. ConfirmNo file namestill carries theneeds attentionbadge, preserving the non-happy-path behavior for an unresolved save failure.cargo test --lib notification::tests,cargo test --lib editor::notifications::tests, andcargo test --test notifications.