fix(lsp): preserve auto-imports after continued typing - #329
Merged
Conversation
fcoury
force-pushed
the
fcoury/completion-auto-import
branch
from
August 23, 2026 16:49
8200e0e to
8f8966b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Rust auto-import candidates defer their import edits until
completionItem/resolve. When the user continued typing while the completion menu stayed open, the selected item still carried opaque server data and ranges from the earlier request. rust-analyzer could no longer match that stale item, so Red inserted the completion text without its import.What Changed
How to Test
module::Somethingoutside the current scope and typeSomat a use site.ewhile the menu remains open, then selectSomething (auto import module::Something).Somethingand the correspondingusestatement.Automated coverage:
cargo test completion_resolve -- --nocapturecargo test --test completion -- --nocapturecargo clippy --all-targets --all-features -- -D warnings