fix(picker): prioritize distinctive primary labels - #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Name-oriented pickers currently give repeated paths and secondary metadata enough space to truncate long labels before their distinguishing suffixes appear. Document symbols are especially difficult to scan because every row repeats the current file.
What changed
line:column; keep full workspace-symbol locations; and display references and worktrees basename-first without losing full-path filtering or highlighted parent-directory matches.How to Test
line:column. Invoke Workspace Symbols and confirm cross-file locations still include their paths.filename:line:columnfollowed by its parent directory; search a directory name and then a:line:columnsuffix, confirm both still match, and select a result to verify it opens the original location.cargo test --libandcargo test --test lsp_lazy --test self_check; expect 2,374 library tests, 48 LSP integration tests, and both bundled-plugin executable checks to pass.cargo test --lib file_picker_large_workspace_performance -- --ignored --nocaptureandcargo clippy --all-targets --all-features -- -D warnings; expect the 12,000-file picker benchmark and warning-free all-feature linting to pass.