fix(editor): seed multi-cursor from visual selection - #354
Merged
Conversation
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b8e532bba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Characterwise Visual selections could not start a multi-cursor session with
Ctrl-n. The key was only reachable in Normal mode, and the occurrence engine only knew how to derive a whole word from the cursor rather than consume an explicit selection.This change lets a single-line characterwise Visual selection seed multi-cursor editing directly. The selected text is matched literally, the next occurrence is added immediately, and Red transitions through its normal Visual-to-Normal path so
gvcan restore the original selection. Normal-modeCtrl-nkeeps its whole-word behavior. Multiline, Visual Line, and Visual Block selections remain unchanged and a multiline character selection reports the supported boundary.The multi-cursor guide and Vim compatibility matrix now describe both entry paths.
How to Test
foobar foo foobar, place the cursor on the firstf, and pressvllfollowed byCtrl-n.Expected: Red enters
MULTI 2/2, selecting thefooprefix and the standalone nextfoo.c, typeX, and pressEsc.Expected: the line becomes
Xbar X foobar; oneurestores the entire edit.Ctrl-n.Expected: Red remains in Visual mode and reports that occurrence selection requires a single-line Visual selection.
Ctrl-non a word beside a longer identifier containing that word.Expected: the existing whole-word selection behavior is unchanged.
Focused automated coverage:
cargo test --test multi_cursorcargo test --lib editing::multi_selection::testscargo clippy --all-targets --all-features -- -D warnings