I43 sign up page - #111
Merged
Merged
Conversation
…/elucidate into i43-sign_up_page
added 3 commits
July 16, 2022 16:41
jsun1590
commented
Jul 18, 2022
| this.accountCreated = true; | ||
|
|
||
| // Print input values | ||
| console.log(document.getElementsByName('First Name')[0].value); |
Contributor
Author
There was a problem hiding this comment.
Field values can be accessed more concisely like so
This is implemented downstream in i119 if you want to take a look
jsun1590
marked this pull request as ready for review
July 20, 2022 09:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
[Briefly summarise the changes that you made. Just high-level stuff]
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
[Is there anything in particular in the review that I should be aware of?]
Related issue