Skip to content

[HOTFIX] I152 change django port to 8081 and fix .env.example - #153

Merged
CodeWithTheDoctor merged 1 commit into
mainfrom
i152-hotfix_revert_default_django_port_and_fix_env_example
Jul 24, 2022
Merged

[HOTFIX] I152 change django port to 8081 and fix .env.example#153
CodeWithTheDoctor merged 1 commit into
mainfrom
i152-hotfix_revert_default_django_port_and_fix_env_example

Conversation

@jsun1590

@jsun1590 jsun1590 commented Jul 24, 2022

Copy link
Copy Markdown
Contributor

Change Summary

[Briefly summarise the changes that you made. Just high-level stuff]

  • Revert default Django port to 8081
  • fix .env.example missing closing "

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

Related issue

@vercel

vercel Bot commented Jul 24, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
elucidate-frontend ✅ Ready (Inspect) Visit Preview Jul 24, 2022 at 3:13PM (UTC)

@jsun1590 jsun1590 changed the title change django port to 8081 and fix .env.example [HIOTFIX] I152 change django port to 8081 and fix .env.example Jul 24, 2022
@jsun1590 jsun1590 changed the title [HIOTFIX] I152 change django port to 8081 and fix .env.example [HOTFIX] I152 change django port to 8081 and fix .env.example Jul 24, 2022
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #153 (44cecde) into main (65ab55a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files          34       34           
  Lines         523      523           
=======================================
  Hits          470      470           
  Misses         53       53           
Flag Coverage Δ
backend 89.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/api/settings.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ab55a...44cecde. Read the comment docs.

@CodeWithTheDoctor
CodeWithTheDoctor merged commit 8415a54 into main Jul 24, 2022
@CodeWithTheDoctor
CodeWithTheDoctor deleted the i152-hotfix_revert_default_django_port_and_fix_env_example branch July 24, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hotfix: revert default Django port and fix .env.example

3 participants