Skip to content

[WIP] I50 create user app - #77

Merged
jsun1590 merged 17 commits into
mainfrom
i50-create_user_app
Jul 20, 2022
Merged

[WIP] I50 create user app#77
jsun1590 merged 17 commits into
mainfrom
i50-create_user_app

Conversation

@KyleCapelli

@KyleCapelli KyleCapelli commented Jul 3, 2022

Copy link
Copy Markdown
Collaborator

Change Summary

[Briefly summarise the changes that you made. Just high-level stuff]

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

Related issue

@vercel

vercel Bot commented Jul 3, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
elucidate-frontend ✅ Ready (Inspect) Visit Preview Jul 20, 2022 at 2:44PM (UTC)

@gitguardian

gitguardian Bot commented Jul 14, 2022

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
3696038 Django Secret Key 2bcdff0 .env.example View secret
3696038 Django Secret Key 2bcdff0 .env.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@codecov-commenter

codecov-commenter commented Jul 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #77 (875a4f1) into main (ead2946) will decrease coverage by 9.52%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   42.85%   33.33%   -9.53%     
==========================================
  Files           7        8       +1     
  Lines           7        9       +2     
  Branches        1        2       +1     
==========================================
  Hits            3        3              
- Misses          4        6       +2     
Flag Coverage Δ
frontend 33.33% <0.00%> (-9.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/pages/quiz.vue 0.00% <ø> (ø)
client/pages/signup.vue 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead2946...875a4f1. Read the comment docs.

@jsun1590
jsun1590 merged commit 38b47a9 into main Jul 20, 2022
@jsun1590
jsun1590 deleted the i50-create_user_app branch July 20, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create user app in Django

3 participants