Skip to content

docs: Add admin-app framework CSS files to license - #82

Merged
jackgranatowski merged 1 commit into
mainfrom
claude/license-css-files-4wccxz
Jun 28, 2026
Merged

docs: Add admin-app framework CSS files to license#82
jackgranatowski merged 1 commit into
mainfrom
claude/license-css-files-4wccxz

Conversation

@jackgranatowski

@jackgranatowski jackgranatowski commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Updates the license.txt file to include references to the admin-app framework CSS files that are part of the SLASHED CSS Framework distribution. This ensures proper attribution and licensing documentation for all framework CSS assets.

Type

  • docs
  • fix
  • feat
  • chore / tooling

Checklist

  • Conventional Commit messages (feat:, fix:, docs:, …)
  • npm test passes
  • npm run lint passes (stylelint + php -l)
  • npm run verify passes (version metadata in sync)
  • Generated artifacts not hand-edited (dist/, data/inventory.json, data/classes-hints.json come from update-framework / build:data)
  • CHANGELOG.md updated under ## [Unreleased] (for user-facing changes)
  • Built SPA assets committed if editor-app/admin-app source changed

Notes

This is a documentation-only change to the license file. No source code modifications or functional changes are included.

https://claude.ai/code/session_01JZ6EMT38ejDPmj4qULPwDc

Summary by CodeRabbit

  • Documentation
    • Updated the third-party licenses list to include additional separately licensed CSS assets.

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jackgranatowski, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 57 minutes and 43 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d1a16ffc-b2ea-46ff-8013-928136c8d946

📥 Commits

Reviewing files that changed from the base of the PR and between fdea04f and 5f552ab.

📒 Files selected for processing (1)
  • SLASHED-for-WP/license.txt
📝 Walkthrough

Walkthrough

Two CSS file paths (assets/admin-app/app.css and integrations/bricks/assets/editor-app/app.css) are added to the enumerated list under the "THIRD-PARTY LICENSES" section of license.txt. No other content is modified.

Changes

License File Update

Layer / File(s) Summary
Add CSS assets to THIRD-PARTY LICENSES
SLASHED-for-WP/license.txt
Two entries added to the third-party licenses list: assets/admin-app/app.css and integrations/bricks/assets/editor-app/app.css.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the documentation-only license update and names the main added CSS asset group.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/license-css-files-4wccxz

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Document admin-app framework CSS assets in third‑party license
📝 Documentation 🕐 Less than 10 minutes

Grey Divider

Description

• Add admin-app framework CSS file paths to the SLASHED CSS Framework license notice.
• Ensure licensing/attribution covers all distributed framework CSS assets.
High-Level Assessment

The following are alternative approaches to this PR:

1. Generate license entries from a build manifest
  • ➕ Prevents future omissions when new assets are added/renamed
  • ➕ Keeps license.txt in sync with shipped artifacts automatically
  • ➖ Adds tooling complexity and a new step in the release/build process
  • ➖ Requires defining the source of truth (manifest/inventory) and maintaining it
2. Reference a directory-level inclusion instead of enumerating files
  • ➕ Less maintenance when files change within the directory
  • ➕ Shorter license.txt entry
  • ➖ May be less explicit than some compliance expectations
  • ➖ Harder for auditors to map attribution to specific shipped files

Recommendation: The PR’s explicit enumeration is appropriate for a small, finite set of distributed CSS files and is low-risk. If the framework-css directory is expected to evolve frequently, consider a follow-up to generate/license-sync these entries from an authoritative build inventory to avoid missing future files.

Files changed (1) +8 / -0

Documentation (1) +8 / -0
license.txtAdd framework-css asset paths to SLASHED CSS Framework license notice +8/-0

Add framework-css asset paths to SLASHED CSS Framework license notice

• Extends the existing SLASHED CSS Framework third-party notice to include admin-app/framework-css file paths. This ensures the license documentation explicitly covers the admin-app packaged framework CSS assets.

SLASHED-for-WP/license.txt

@jackgranatowski
jackgranatowski force-pushed the claude/license-css-files-4wccxz branch from 7435d2d to df01564 Compare June 28, 2026 16:41
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@jackgranatowski
jackgranatowski force-pushed the claude/license-css-files-4wccxz branch from df01564 to fdea04f Compare June 28, 2026 17:50
…cope

Replace brittle file-by-file enumeration with a directory-level
description covering all current and future SLASHED CSS Framework
assets bundled in the plugin.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JZ6EMT38ejDPmj4qULPwDc
@jackgranatowski
jackgranatowski force-pushed the claude/license-css-files-4wccxz branch from fdea04f to 5f552ab Compare June 28, 2026 17:51

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
SLASHED-for-WP/license.txt (1)

347-355: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add the missing shipped CSS assets to the attribution list. license.txt still omits at least assets/admin-app/app.css and integrations/bricks/assets/editor.css, both of which are enqueued at runtime. If this list is meant to cover all framework CSS bundles, include every shipped entrypoint, not just the current subset.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@SLASHED-for-WP/license.txt` around lines 347 - 355, The attribution list in
license.txt is incomplete for shipped CSS bundles; add every runtime-enqueued
CSS entrypoint to the bundled-files section. Update the list near the existing
dist/slashed.* and assets/admin-app/app.css entries to also cover the missing
shipped assets, including integrations/bricks/assets/editor.css, so the license
notice matches all distributed framework CSS outputs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@SLASHED-for-WP/license.txt`:
- Around line 347-355: The attribution list in license.txt is incomplete for
shipped CSS bundles; add every runtime-enqueued CSS entrypoint to the
bundled-files section. Update the list near the existing dist/slashed.* and
assets/admin-app/app.css entries to also cover the missing shipped assets,
including integrations/bricks/assets/editor.css, so the license notice matches
all distributed framework CSS outputs.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4960a0c3-2418-410e-b87f-49359eb5183e

📥 Commits

Reviewing files that changed from the base of the PR and between ef63d46 and fdea04f.

📒 Files selected for processing (1)
  • SLASHED-for-WP/license.txt

@jackgranatowski
jackgranatowski merged commit 29a7aef into main Jun 28, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants