Skip to content

fix: resolve pre-freeze audit items (9 remaining 🟠) - #118

Closed
kiro-agent[bot] wants to merge 2 commits into
mainfrom
audit-fixes-pre-freeze
Closed

fix: resolve pre-freeze audit items (9 remaining 🟠)#118
kiro-agent[bot] wants to merge 2 commits into
mainfrom
audit-fixes-pre-freeze

Conversation

@kiro-agent

@kiro-agent kiro-agent Bot commented May 27, 2026

Copy link
Copy Markdown

This pull request was created by @kiro-agent on behalf of @jackgranatowski 👻

Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro autonomous agent


Pre-freeze audit resolution

Addresses all remaining 🟠 items from the v0.3.0 API audit. After this PR, the only open items are 🟡 (cosmetic/historical, safe to defer).

Changes

API additions:

  • .sf-icon--2xl (4em) — full xs..2xl parity across all size-aware primitives
  • .sf-focus-parent — canonical prefixed name for the focus-parent pattern (.focus-parent kept as legacy alias)
  • --sf-icon-2xl token

Documentation (new files):

  • docs/motion.md — full animation/transition catalogue (9 direct classes, 6 entrance classes, 5 keyframes-only, 14 preset tokens, stagger delays, duration/easing tables)

Documentation (updated):

  • docs/architecture.md — "Naming exceptions" section, flat bundles docs, palette stability contract in "Known intentional tradeoffs"
  • docs/layout.md — updated size-modifier table (full parity, no exception)
  • docs/registry.json — added unprefixed_classes array, updated counts, added new class/token

Bug fixes / hygiene:

  • core/tokens.css--sf-clickable-overlay-z added to PUBLIC scoped override tokens list
  • optional/forms.css — TOKENS CONSUMED header completed (--sf-radius-full, --sf-border-width-3, --sf-color-action-hover)
  • optional/theme-example.css — rewritten as maximal copy-paste reference with ALL overridable tokens (15 sections, all commented out)

Testing

  • No runtime behaviour changes — all additions are additive CSS classes/tokens
  • Existing tests unaffected (new class .sf-icon--2xl follows identical pattern to existing size modifiers)

kiro-agent and others added 2 commits May 27, 2026 09:10
…3, G.6, G.4)

- B.2: Add .sf-icon--2xl (4em) for full xs..2xl parity across all primitives
- A.2: Add --sf-clickable-overlay-z to PUBLIC scoped override tokens
- B.3: Add 'Naming exceptions' section to architecture.md (11 unprefixed classes)
- B.4: Add .sf-focus-parent as canonical prefixed name (alias of .focus-parent)
- C.3: Create docs/motion.md (full animation/transition catalogue)
- C.5: Add unprefixed_classes to registry.json incl. .theme-transition
- E.3: Document flat bundles in architecture.md (what, when, how)
- G.6: Complete forms.css TOKENS CONSUMED header (add 3 missing tokens)
- G.4: Rewrite theme-example.css as maximal copy-paste reference
- G.3: Add palette stability contract to 'Known intentional tradeoffs'

Co-authored-by: Jack Granatowski <contact@codeslash.net>
No users before 0.5 — skip the deprecation cycle entirely.
Updated: accessibility.css, architecture.md, states.md, migration.md,
browser-support.md, demo.html, registry.json, layers.spec.js.
@jackgranatowski
jackgranatowski deleted the audit-fixes-pre-freeze branch May 31, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants