fix: restore --sf-shadow-color and --sf-prose-paragraph to tokens.css - #12
Conversation
Token names in tokens.css are part of the public API — they must not be removed regardless of current usage. Restores both variables erroneously dropped in the CSS audit commit (5ad6670). https://claude.ai/code/session_01UykVy4gmFJEFgFfTGqDjYr
Token was dropped during light/dark mode refactor but is consumed by reset.css and belongs in tokens.css per the rule that token names are never removed. https://claude.ai/code/session_01UykVy4gmFJEFgFfTGqDjYr
Both reset.css and base.css now read from the token, making --sf-color-scheme a single source of truth for the default color-scheme. https://claude.ai/code/session_01UykVy4gmFJEFgFfTGqDjYr
Single-file demo at docs/demo.html covering all framework layers: tokens (colors, typography, spacing, shadows, radius), reset, base, motion, accessibility, light/dark toggle, and all 13 layout primitives. https://claude.ai/code/session_01UykVy4gmFJEFgFfTGqDjYr
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR makes the root color-scheme configurable via a new ChangesDesign System Demo and Theme Configuration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/demo.html`:
- Around line 1078-1080: The inner landmark uses a <main> element (<main
class="demo-box">) nested inside the page's primary <main id="main"> which is
invalid; replace the inner <main> with a non-landmark container such as a <div>
or <section> (e.g., <div class="demo-box"> or <section class="demo-box"
role="region" aria-label="Demo">) so it preserves styling/semantics without
creating a nested main; update any references to the inner element if they rely
on it being a <main>.
- Line 465: The demo heading uses the wrong CSS token name: replace the
incorrect token reference --sf-h2-font-size in the h2 element's inline style
with the correct token --sf-h2-size so the heading follows the defined scale;
locate the h2 element in docs/demo.html (the element showing "h2 — The quick
brown fox") and update its style attribute to use --sf-h2-size.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ce12abfb-eec3-42ec-9dae-1bfb8c851698
⛔ Files ignored due to path filters (1)
dist/slashed.essential.cssis excluded by!**/dist/**
📒 Files selected for processing (3)
core/base.csscore/tokens.cssdocs/demo.html
- Replace --sf-h2-font-size with correct token --sf-h2-size (line 465) - Replace nested <main> with <div> in pancake demo (invalid landmark nesting) https://claude.ai/code/session_01UykVy4gmFJEFgFfTGqDjYr
Token names in tokens.css are part of the public API — they must not be
removed regardless of current usage. Restores both variables erroneously
dropped in the CSS audit commit (5ad6670).
https://claude.ai/code/session_01UykVy4gmFJEFgFfTGqDjYr
Summary by CodeRabbit
New Features
Documentation
Chores