fix: resolve pre-freeze API audit findings - #126
Merged
Conversation
- tokens.css: add --sf-icon-2xl to PUBLIC tier classification - architecture.md: fix alias hop count ≤2 → ≤3 to match tokens.css - tokens.md: fix tier reference (PUBLIC/PUBLIC-ADVANCED/INTERNAL) - .stylelintrc.json: enforce single-dash/double-dash naming semantics - components.md: rename --destructive to --danger for consistency - CHANGELOG.md: remove false 'icon caps at xl' claim (has 2xl) - layout.md: add .sf-gap, .sf-equal, .sf-section--collapse docs - motion.md: correct stale duration/delay token values - migration.md: add [Unreleased] pre-freeze breaking changes section Co-authored-by: Jack Granatowski <contact@codeslash.net>
Aligns the commented component scaffold with docs/components.md and the consistent 'danger' intent modifier used across the API (.is-danger, .sf-surface--danger, --sf-color-danger-*). Adds a migration note.
The generator template still referenced 'PUBLIC / INTERNAL / DEPRECATED' which caused docs-freshness CI to fail (generator overwrites our corrected tokens.md header). Updated to PUBLIC / PUBLIC-ADVANCED / INTERNAL with the DEPRECATED note for post-0.5.0.
Updates the stale 'PUBLIC / INTERNAL / DEPRECATED' reference to 'PUBLIC / PUBLIC-ADVANCED / INTERNAL' and corrects the alias hop limit from ≤2 to ≤3, consistent with core/tokens.css and docs/architecture.md.
jackgranatowski
pushed a commit
that referenced
this pull request
May 27, 2026
PR #127 wired zip-plugin.js into the build chain but didn't commit the generated dist/slashed-bricks.zip artifact (required by release.yml). Also refreshes the ten .min.css.map files whose sources changed in PRs #125–#126 but whose built output was never re-committed. https://claude.ai/code/session_01CkF1n21vhFAfscxSarXuCD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created by @kiro-agent on behalf of @jackgranatowski 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro autonomous agent
Summary
Resolves all findings from the pre-freeze API audit (9 issues across documentation drift, naming inconsistencies, and tooling gaps).
Changes
core/tokens.css— Add--sf-icon-2xlto the PUBLIC tier classification in the header (was missing despite token+class existing)docs/architecture.md— Fix alias hop count from "≤2" to "≤3 hops (per-primitive → layout-system → canonical source)" matching the contract intokens.cssdocs/tokens.md— Replace stale "PUBLIC / INTERNAL / DEPRECATED" with "PUBLIC / PUBLIC-ADVANCED / INTERNAL"; note DEPRECATED tier will return post-0.5.0.stylelintrc.json— Upgradecustom-property-patternfrom bare^sf-prefix to a structural regex enforcing the single-dash (shade) / double-dash (application slot) naming conventiondocs/components.md— Rename.sf-button--destructiveto.sf-button--dangerfor consistency with.is-dangerstate namingCHANGELOG.md— Remove false "icon caps at --xl" claim;.sf-icon--2xlexists and is intentionaldocs/layout.md— Add missing primitives.sf-gap,.sf-equal,.sf-section--collapseto reference table and size-modifier tabledocs/motion.md— Correct all stale duration values (instant 50→100ms, normal 300→250ms, slow 500→400ms, slower 800→600ms) and delay values (delay-1..5 recalculated)docs/migration.md— Add comprehensive "0.3.0 → pre-freeze" section documenting all removed tokens, removed class modifiers, and added modifiersTesting
--sf-*token names pass the new stylelint regex pattern