fix(tokens): correct raised surface level, on-inverse text, shadow glow, space-scale integration; clarify cq breakpoint tokens - #13
Conversation
…ow, space-scale integration; clarify cq breakpoint tokens - --sf-color-raised: l+0.02 → l+0.04 so hierarchy well < surface < bg < raised is correct - --sf-color-text--on-inverse: var(--sf-color-text) → var(--sf-color-text--inverse) — dark text on dark inverse surface was unreadable in light mode - --sf-shadow-glow: replace color-mix(calc%) with oklch relative color syntax — calc() inside color-mix() percentage is not guaranteed by spec across browsers - --sf-space-*: wrap fluid clamp() in calc(... * var(--sf-space-scale)) — makes space-scale a working multiplier like radius-scale and motion-scale - --sf-cq-*: add comment explaining custom properties cannot be used in @container/@media queries; values are JS-readable reference constants https://claude.ai/code/session_01EwbavhVkyG2whvrf376rei
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated core/tokens.css: color tokens ( ChangesDesign Token Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
Custom properties cannot be used in @container/@media queries, and nothing in the codebase reads them. layout.css hardcodes the same values directly where needed. https://claude.ai/code/session_01EwbavhVkyG2whvrf376rei
https://claude.ai/code/session_01EwbavhVkyG2whvrf376rei
Summary by CodeRabbit
Style
Documentation