Skip to content

remove redundant .visually-hidden alias from .sr-only rule - #133

Merged
jackgranatowski merged 1 commit into
mainfrom
claude/sr-only-visually-hidden-J2PeV
May 28, 2026
Merged

remove redundant .visually-hidden alias from .sr-only rule#133
jackgranatowski merged 1 commit into
mainfrom
claude/sr-only-visually-hidden-J2PeV

Conversation

@jackgranatowski

@jackgranatowski jackgranatowski commented May 28, 2026

Copy link
Copy Markdown
Contributor

.sr-only is the canonical class name used throughout the codebase.
.visually-hidden was an unused alias with zero references in source files.

https://claude.ai/code/session_01T9rkawoF9WH2ZzXnkBJ9SV

Summary by CodeRabbit

  • Style
    • Updated screen-reader-only styling rules to adjust how hidden accessibility content is displayed and positioned within the application interface.

Review Change Stack

.sr-only is the canonical class name used throughout the codebase.
.visually-hidden was an unused alias with zero references in source files.

https://claude.ai/code/session_01T9rkawoF9WH2ZzXnkBJ9SV
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 408107ad-3414-4476-86f9-5253fa10f27f

📥 Commits

Reviewing files that changed from the base of the PR and between 4f4f709 and 8aa24a8.

⛔ Files ignored due to path filters (11)
  • dist/slashed-bricks.zip is excluded by !**/dist/**, !**/*.zip
  • dist/slashed.essential.css is excluded by !**/dist/**
  • dist/slashed.essential.flat.css is excluded by !**/dist/**
  • dist/slashed.full.css is excluded by !**/dist/**
  • dist/slashed.full.flat.css is excluded by !**/dist/**
  • dist/slashed.optimal-components.css is excluded by !**/dist/**
  • dist/slashed.optimal-components.flat.css is excluded by !**/dist/**
  • dist/slashed.optimal-utilities.css is excluded by !**/dist/**
  • dist/slashed.optimal-utilities.flat.css is excluded by !**/dist/**
  • dist/slashed.optimal.css is excluded by !**/dist/**
  • dist/slashed.optimal.flat.css is excluded by !**/dist/**
📒 Files selected for processing (1)
  • core/accessibility.css
💤 Files with no reviewable changes (1)
  • core/accessibility.css

📝 Walkthrough

Walkthrough

The PR removes .visually-hidden from the "screen-reader-only" hardened selector group in core/accessibility.css. Elements using .visually-hidden alone no longer receive the absolute-position + clipped styling previously applied via this rule; only .sr-only remains in the shared selector group.

Changes

Screen Reader Hidden Class Cleanup

Layer / File(s) Summary
Remove .visually-hidden from screen-reader-only selector
core/accessibility.css
The .visually-hidden class is removed from the selector group that targets .sr-only / .sr-only-focusable:not(:focus, :focus-within), decoupling its styling from the hardened offscreen rule set.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

  • #123: Directly related; proposes consolidating or choosing between .sr-only and .visually-hidden classes, which this change addresses by removing .visually-hidden from the shared selector group.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing a redundant .visually-hidden alias from the .sr-only rule, which matches the actual modification in core/accessibility.css.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/sr-only-visually-hidden-J2PeV

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jackgranatowski
jackgranatowski merged commit 0ccf2b4 into main May 28, 2026
5 checks passed
@jackgranatowski
jackgranatowski deleted the claude/sr-only-visually-hidden-J2PeV branch May 31, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants