Skip to content

fix(preview): dark swatches respect the dark-overrides-enabled toggle #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackgranatowski merged 3 commits into from
May 29, 2026
Merged

fix(preview): dark swatches respect the dark-overrides-enabled toggle #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18312ac
fix(preview): dark swatches respect the dark-overrides-enabled toggle
claude May 29, 2026
b466a2f
fix(preview): partial dark overrides fall back to auto-derivation
claude May 29, 2026
d5ce9e3
refactor(preview): hoist dark-formula helpers to module level
claude May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions integrations/bricks/admin-app/src/components/LivePreview.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,17 @@
const statuses = ['success', 'warning', 'error', 'info', 'danger'];
const defaultColors = meta.defaults?.colors ?? {};

// Auto-derivation formulas matching core/tokens.css verbatim.
// Module-level so they're defined once, not recreated per render.
const autoDarkStandard = (light) =>
`oklch(from var(${light}) clamp(0.65, calc(0.95 - l * 0.5), 0.88) calc(c * 0.9) h)`;
const autoDarkBase = (light) =>
`oklch(from var(${light}) clamp(0.16, calc(1.18 - l), 0.24) calc(c * 0.5) h)`;
const autoDark = (name) => {
const light = `--sf-color-${name}-light`;
return name === 'base' ? autoDarkBase(light) : autoDarkStandard(light);
};

/** Light / dark mode toggle for the preview panel. */
let darkMode = $state(false);

Expand All @@ -43,17 +54,22 @@
const radius = tokens.radius ?? {};
const shadows = tokens.shadows ?? {};

// When dark overrides are disabled the framework auto-derives dark colors
// via CSS relative color syntax. Mirror that exactly so the preview matches
// what the front-end actually renders. When enabled, use stored values.
const darkEnabled = colors.dark_overrides_enabled !== '0';

for (const name of brand) {
const v = colors[`brand_${name}`] ?? defaultColors.brand_hex_hints?.[name];
if (v) pairs.push(`--sf-color-${name}-light:${v}`);
const vd = colors[`brand_dark_${name}`] ?? defaultColors.brand_dark_hex_hints?.[name];
if (vd) pairs.push(`--sf-color-${name}-dark:${vd}`);
const storedDark = darkEnabled ? colors[`brand_dark_${name}`] : '';
pairs.push(`--sf-color-${name}-dark:${storedDark || autoDark(name)}`);
}
for (const name of statuses) {
const v = colors[`status_${name}`] ?? defaultColors.status_hex_hints?.[name];
if (v) pairs.push(`--sf-color-${name}-light:${v}`);
const vd = colors[`status_dark_${name}`] ?? defaultColors.status_dark_hex_hints?.[name];
if (vd) pairs.push(`--sf-color-${name}-dark:${vd}`);
const storedDark = darkEnabled ? colors[`status_dark_${name}`] : '';
pairs.push(`--sf-color-${name}-dark:${storedDark || autoDark(name)}`);
}
if (typography.font_body) pairs.push(`--sf-font-body:${typography.font_body}`);
if (typography.font_heading) pairs.push(`--sf-font-heading:${typography.font_heading}`);
Expand Down
Loading