feat(bricks): SF Colors panel — pick flow, icon, and remove Color Manager palette injection - #202
Conversation
The class injected SLASHED tokens into Bricks' Color Manager as static hex values, which overrides the framework's adaptive light-dark() tokens in :root and breaks dark/light switching. The SF Colors panel is the correct entry point for token selection in Bricks. - Delete includes/class-colors.php - Remove require_once, instantiation, and dead slashed_bricks_supports_color_manager() function from slashed-bricks.php - Tighten stale Color Manager comment in class-inventory.php https://claude.ai/code/session_01HesqASnoEx3Amm4H7f17jj
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR removes the Bricks color manager integration entirely. The ChangesBricks Color Manager Integration Removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
$(cat <<'EOF'
Summary
class-colors.php— the class injected SLASHED tokens into Bricks' Color Manager as static hex values, overriding the framework's adaptivelight-dark()tokens in:rootand breaking dark/light switching. The SF Colors panel is the correct entry point for token selection; no Color Manager palette injection is needed.documentwas closing the settings panel when clicking inside the SF Colors panel. Addedonclick/onmousedownstopPropagationon theColorPanelroot..color-inputcontrol after each value change, destroying the injected button.injectSFButtonnow reads the live input value on every injection and restores the active state and hex dot.bricks-control-transparency-patternusescolor: currentColor, notbackground. The pick handler now sets bothbackgroundandcolorwith!importantso the swatch updates on all control types.border-radius: 5px). Smooth expand/shrink transition on both base and active states.border(bleeds pastoverflow:hiddencorners) tobox-shadow: inset.surfacebrand family →baseacross the full codebase (tokens, classes, PHP, JS, docs).--sf-color-surfaceis retained as a semantic alias (var(--sf-color-base)).docs/tokens.md,docs/registry.json,docs/classes.md; fixed stale--sf-color-surface-lightexamples in README, CHANGELOG, and docs; fixedgen-class-reference.jsdouble-count ofsf-link-external.Test plan
--sf-color-base-*tokens appear in Bricks Variable Manager;--sf-color-surfacealias also presenthttps://claude.ai/code/session_01HesqASnoEx3Amm4H7f17jj
EOF
)
Generated by Claude Code
Summary by CodeRabbit