Make framework plugin-agnostic and fix release version drift - #263
Conversation
The WordPress/Bricks/Gutenberg plugin now lives in its own repo. Strip leftover plugin coupling from the framework so it stays plugin-agnostic: - drop stale plugins/SLASHED-for-WP build-artifact paths from .gitignore - genericize WP/page-builder comments in reset.css and base.css - remove the 'WP plugin CSS generator' note from tokens.css - replace Bricks/WooCommerce/Gravity Forms examples in overrides-example with generic third-party wording Co-authored-by: Jack Granatowski <contact@codeslash.net>
package.json on main was never bumped past 0.5.21, so build-time bundle headers were stamped with the wrong version. version-sync.yml could never run: it triggered on the release event, but releases created with the built-in GITHUB_TOKEN do not emit events. package-lock had also drifted to 0.6.0. - set package.json, package-lock.json and roadmap to current 0.5.23 - fold the main-sync step into release.yml on the tag-push trigger so it always runs, and drop [skip ci] so publish-dist rebuilds the dist branch - delete the dead version-sync.yml workflow Co-authored-by: Jack Granatowski <contact@codeslash.net>
|
Warning Review limit reached
More reviews will be available in 14 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (13)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Harden the version pipeline against mis-stamped artifacts: - bundle.js derives the header version from the git tag when building at a tag (GITHUB_REF / git describe --exact-match), falling back to package.json. A tagged-source build is now correct even if that commit's package.json lags. - release.yml fails the build if any unminified dist header != the tag being released, preventing silent mis-stamping. - add scripts/check-version-sync.js (npm run check:version) asserting package-lock.json and docs/roadmap.md match package.json; wired into CI.
2 participants
This pull request was created by @kiro-agent on behalf of @jackgranatowski 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro Web
Summary
Follow-up to the plugin split (#262). Removes leftover integration references from the framework and fixes the version pipeline that left bundle headers stamped with a stale version.
Plugin cleanup (commit 1)
The WordPress/Bricks/Gutenberg plugin now lives in
SLASHED-Plugins. This strips the remaining plugin coupling so the framework stays plugin-agnostic:.gitignore— removed staleplugins/SLASHED-for-WP/...build-artifact ignore paths (that directory no longer exists here)core/reset.css,core/base.css— genericizedWP admin bar/page-buildercomments to neutral "admin toolbars / embedded widget chrome"core/tokens.css— removed the "mirrors the WP plugin's CSS generator" noteoptional/overrides-example.css— replaced the Bricks/WooCommerce/Gravity Forms examples with generic third-party wordingThe README pointer to the plugin repo was left in place per discussion (it is a discoverability link, not coupling).
Version drift + pipeline fix (commit 2)
Problem: generated bundle headers read
v0.5.21while the current release isv0.5.23. The header is stamped at build time frompackage.json, which was never bumped onmain.package-lock.jsonhad separately drifted to0.6.0.Root cause:
version-sync.ymlwas triggered byon: release, but releases created byrelease.ymluse the built-inGITHUB_TOKEN, and GitHub does not emit events for token-driven actions — so the sync workflow never ran.Fix:
package.json,package-lock.json, anddocs/roadmap.mdto0.5.23release.ymlon the tag-push trigger (a real event that always fires); the sync commit omits[skip ci]sopublish-dist.ymlrebuilds thedistbranch with the correct headerversion-sync.ymlThis makes every release path (local
npm run release, pushed tag,workflow_dispatch, UI release) end withpackage.json, thedistbranch, and the Release assets all stamped identically — no manual step.Testing
node scripts/bundle.jsnow emits/* SLASHED v0.5.23 — ... */plugin/WordPress/Bricks/Gutenberg/WooCommerce/Gravityreferences incore/,optional/,docs/,tests/, orscripts/Notes
CI runs stylelint and the test suite; I could not run those locally because
node_modulesis not installed in the sandbox. Git hooks were inactive (nocore.hooksPath), so commits were not locally linted.