Docs/API sync cleanup: fix phantom refs + retire unused border-style tokens - #270
Conversation
demo.html and test-coverage.html referenced tokens/classes that do not exist in the CSS sources: - --sf-pancake-min-height: dead inline var; .sf-pancake hardcodes min-height - --sf-brand: replaced with the real --sf-prose-marker-color - --sf-color-X / .sf-grid-N: changed to --sf-color-* / .sf-grid-* wildcard notation - --sf-measure: replaced with the real --sf-container-prose token Co-authored-by: Jack Granatowski <contact@codeslash.net>
…tyle-dotted These two tokens were never consumed by any core or optional CSS rule; the only references were a single demo page. They added public API surface (docs, snapshot, back-compat liability) without theming value, since 'dashed'/'dotted' are short universal CSS keywords. The global knob --sf-border-style (consumed by every border shorthand and base element border) is kept. - Remove declarations from core/tokens.css and the commented mirror in optional/theme-example.css - Fix the token-inventory comment that also listed a never-existent --sf-border-style-strong - Update the demo to use literal dotted/dashed keywords - Regenerate registry.json, tokens.md, token-index.* (771 -> 769) - Resync the test-coverage-6 token reference array and the token-api snapshot lock BREAKING CHANGE: --sf-border-style-soft and --sf-border-style-dotted are removed with no alias. Use the CSS keywords 'dashed' / 'dotted' directly, or set --sf-border-style globally. Co-authored-by: Jack Granatowski <contact@codeslash.net>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR removes two border-style custom properties ( ChangesBorder-style token removal
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This pull request was created by @kiro-agent on behalf of @jackgranatowski 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro Web
Summary
Brings the docs back into 100% sync with the framework API and removes dead-weight tokens, in two commits:
1.
fix(docs)— correct phantom token/class referencesSeveral docs referenced tokens/classes that don't exist in the CSS sources:
docs/demo.html--sf-pancake-min-height→ removed (dead inline var;.sf-pancakehardcodesmin-height)--sf-brand→--sf-prose-marker-color(the real token, defaults to--sf-color-primary)--sf-color-X/.sf-grid-N→--sf-color-*/.sf-grid-*wildcard notationdocs/test-coverage.html--sf-measure→--sf-container-prose(the real reading-measure token)2.
feat(tokens)!— remove unused--sf-border-style-soft/--sf-border-style-dottedThese two tokens were never consumed by any core/optional rule (only a single demo page referenced them). They added public API surface without theming value, since
dashed/dottedare short universal CSS keywords. The global knob--sf-border-style(consumed by every border shorthand and base element border) is kept.core/tokens.css+ the commented mirror inoptional/theme-example.css--sf-border-style-strongdotted/dashedkeywordsregistry.json,tokens.md,token-index.*(771 → 769 tokens)test-coverage-6token-reference array and thetoken-apisnapshot lockTesting
npm run audit:check→ OK (769 tokens, 173.sf-, 40.is-)test-coverage-6array vs registry → exact match (769 = 769)CHANGELOG.md, which is release-it–generated)Notes / limitations
dist/*is gitignored (built at release time), so no bundle changes are included here.Summary by CodeRabbit
Documentation
Chores
--sf-border-style-softand--sf-border-style-dottedborder-style tokens from the public token set