Skip to content

fix(configurator): sync framework version stamp on release - #300

Merged
jackgranatowski merged 1 commit into
mainfrom
fix/configurator-version-stamp-sync
Jun 10, 2026
Merged

fix(configurator): sync framework version stamp on release#300
jackgranatowski merged 1 commit into
mainfrom
fix/configurator-version-stamp-sync

Conversation

@jackgranatowski

Copy link
Copy Markdown
Contributor

This pull request was created by @kiro-agent on behalf of @jackgranatowski 👻

Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro Web


Problem

The configurator displayed framework version 0.5.29 while package.json was already at 0.5.30. The panel stamps its version from configurator/src/data/api-index.generated.json_sync.frameworkVersion.

Root cause

  • A release bumps package.json and scripts/version-sync.js re-synced only docs/roadmap.md — it never touched the configurator's generated index.
  • The CI guard scripts/check-version-sync.js checked only package-lock.json + docs/roadmap.md, so the configurator drift passed CI unnoticed every release.

Fix

  • Re-synced configurator/src/data/api-index.generated.json to 0.5.30 (via node configurator/scripts/sync-api.mjs, which reads package.json).
  • scripts/version-sync.js now also bumps the configurator frameworkVersion stamp (it runs in the release-it hooks), and remains idempotent.
  • scripts/check-version-sync.js now fails when the generated index's frameworkVersion differs from package.json, so future drift is caught in CI.

Validation

  • node scripts/check-version-sync.js → exit 0 (version-sync check OK — all references at 0.5.30.)
  • node scripts/version-sync.js → idempotent (both targets already up to date; no churn)
  • configurator npm run check → svelte-check 0 errors / 0 warnings
  • configurator node --test tests/*.test.js42 pass / 0 fail
  • configurator npm run build → compiles successfully

Scope

Only three files changed: the generated index plus the two version-sync scripts. No tabs redesign, no plugin changes.

The configurator stamped its version from the generated api-index
(_sync.frameworkVersion), but a release only bumped package.json and
re-synced docs/roadmap.md — never the configurator index. CI's guard
checked package-lock + roadmap only, so the drift passed unnoticed and
the panel kept showing the previous version (0.5.29 vs 0.5.30).

- Re-sync configurator/src/data/api-index.generated.json to 0.5.30.
- version-sync.js now also bumps the configurator frameworkVersion
  stamp (runs in release-it hooks), keeping it idempotent.
- check-version-sync.js now fails when the generated index drifts from
  package.json, so future releases catch this in CI.
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jackgranatowski, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 44 minutes and 41 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bf851732-dc56-4167-899d-13d716bf70be

📥 Commits

Reviewing files that changed from the base of the PR and between 7f291fd and 720e339.

📒 Files selected for processing (3)
  • configurator/src/data/api-index.generated.json
  • scripts/check-version-sync.js
  • scripts/version-sync.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/configurator-version-stamp-sync

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jackgranatowski
jackgranatowski merged commit ceee916 into main Jun 10, 2026
12 checks passed
jackgranatowski pushed a commit that referenced this pull request Jun 10, 2026
Resolved conflict in configurator/src/data/api-index.generated.json:
kept our tokensHash (reflects description fixes for fluid custom slots).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants