Skip to content

fix(configurator): replace overflow:hidden with overflow:clip - #308

Merged
jackgranatowski merged 1 commit into
mainfrom
fix/overflow-clip-panels
Jun 10, 2026
Merged

fix(configurator): replace overflow:hidden with overflow:clip#308
jackgranatowski merged 1 commit into
mainfrom
fix/overflow-clip-panels

Conversation

@jackgranatowski

Copy link
Copy Markdown
Contributor

This pull request was created by @kiro-agent on behalf of @jackgranatowski 👻

Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro Web


Summary

overflow: hidden on .group (TokenGroup), .panel__card (DomainPanel), and .knobs (QuickKnobs) was causing token rows and subcategory content to be clipped and invisible across all domain tabs (Spacing, Typography, Colors, etc.).

Changes

  • TokenGroup.svelte.group: overflow: hiddenoverflow: clip
  • DomainPanel.svelte.panel__card: overflow: hiddenoverflow: clip
  • QuickKnobs.svelte.knobs: overflow: hiddenoverflow: clip

Why overflow: clip instead of removing it?

overflow: clip still clips rendering at the border-radius boundary (preventing child backgrounds from bleeding outside rounded corners), but unlike hidden it does not create a new scroll container or affect intrinsic/extrinsic sizing calculations. This means child content is no longer collapsed to zero height when the container doesn't have an explicit height.

Testing

  • All 272 existing unit tests pass
  • Visually verified the Spacing panel's token groups are now fully visible

…l cards

overflow:hidden on .group, .panel__card, and .knobs was causing token
rows and subcategory content to be clipped and invisible across all
domain tabs (Spacing, Typography, etc.).

Switched to overflow:clip which still clips content at the border-radius
boundary but does not create a new scroll container or affect intrinsic
sizing — so child content is no longer collapsed.

Co-authored-by: Jack Granatowski <contact@codeslash.net>
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jackgranatowski, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 15 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ce04967e-fbf1-4c58-a96d-fd188094c367

📥 Commits

Reviewing files that changed from the base of the PR and between e532dfd and 6950ef6.

📒 Files selected for processing (3)
  • configurator/src/components/DomainPanel.svelte
  • configurator/src/components/QuickKnobs.svelte
  • configurator/src/components/TokenGroup.svelte
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/overflow-clip-panels

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants