fix(configurator): replace overflow:hidden with overflow:clip - #308
Conversation
…l cards overflow:hidden on .group, .panel__card, and .knobs was causing token rows and subcategory content to be clipped and invisible across all domain tabs (Spacing, Typography, etc.). Switched to overflow:clip which still clips content at the border-radius boundary but does not create a new scroll container or affect intrinsic sizing — so child content is no longer collapsed. Co-authored-by: Jack Granatowski <contact@codeslash.net>
|
Warning Review limit reached
More reviews will be available in 15 minutes and 15 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This pull request was created by @kiro-agent on behalf of @jackgranatowski 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro Web
Summary
overflow: hiddenon.group(TokenGroup),.panel__card(DomainPanel), and.knobs(QuickKnobs) was causing token rows and subcategory content to be clipped and invisible across all domain tabs (Spacing, Typography, Colors, etc.).Changes
.group:overflow: hidden→overflow: clip.panel__card:overflow: hidden→overflow: clip.knobs:overflow: hidden→overflow: clipWhy
overflow: clipinstead of removing it?overflow: clipstill clips rendering at the border-radius boundary (preventing child backgrounds from bleeding outside rounded corners), but unlikehiddenit does not create a new scroll container or affect intrinsic/extrinsic sizing calculations. This means child content is no longer collapsed to zero height when the container doesn't have an explicit height.Testing