Add comprehensive comparative audit against reference CSS frameworks - #33
Conversation
Full 1478-line plik-po-pliku audit against four reference frameworks. Covers: capability matrix (40+ rows), 22 findings (3 critical/3 high/9 medium/5 low/2 nit), P0/P1/P2 roadmap, verification of existing audits, full selector and token inventories. Top findings: browser-support floor mismatch (light-dark/sign/@Property require Safari 17.5 / FF 128+, not declared 15.4/97), empty component/ utility stubs, hardcoded #999 literal + !important in print.css, sign(0.6 - l) contrast threshold fails WCAG AA Normal for tertiary/neutral token pairs, slashed.themes layer declared but never targeted. https://claude.ai/code/session_017pNnrbF63T296c3Abo1RCa
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughA new comparative audit document ( ChangesSLASHED Comparative Audit 2026
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
audits/comparative-audit-2026.md (1)
165-170: ⚡ Quick winAdd per-claim “verified on” dates for external compatibility/doc assertions.
This audit includes time-sensitive compatibility statements; adding a short
(verified: YYYY-MM-DD)marker near each external claim/source section will make future re-audits more reliable.Also applies to: 499-505, 1460-1478
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@audits/comparative-audit-2026.md` around lines 165 - 170, Add a short "(verified: YYYY-MM-DD)" date marker after each time-sensitive external compatibility claim in the "Browser reality" block (for items like `light-dark()`, `@property` with `inherits: true`, `sign()` in `calc()`) and after the "Compared to: Tailwind v4" source line; also apply the same verification-date markers to the other external-claim blocks called out in the review (the other compatibility/claim sections referenced), so each external assertion includes an explicit verification date to aid future re-audits.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@audits/comparative-audit-2026.md`:
- Line 591: The title contains a duplicated token name
`--sf-sf-color-link--visited`; rename it to the correct token
`--sf-color-link--visited` so the audit heading matches the actual token naming
used elsewhere (update the title text "F-21 — `--sf-sf-color-link--visited`
hue-shifts..." to "F-21 — `--sf-color-link--visited` hue-shifts...").
- Around line 175-178: Several fenced code blocks in
audits/comparative-audit-2026.md are missing language identifiers which triggers
markdownlint MD040; update each triple-backtick fence to include an appropriate
tag (use `text` for inventory/plain blocks and `css` for CSS snippets) for the
blocks shown (e.g., the block containing "Requires: Chrome 123+ | Safari 17.5+ |
Firefox 128+" and the many CSS-like blocks starting with selectors like "*,
*::before, *::after", ":root", ".sf-section", ".is-hidden", "`@media`",
":focus:not(:focus-visible)", "`@media` print", and "`@supports`"), ensuring every
opening ``` becomes ```text or ```css as appropriate so the linter warnings are
resolved.
---
Nitpick comments:
In `@audits/comparative-audit-2026.md`:
- Around line 165-170: Add a short "(verified: YYYY-MM-DD)" date marker after
each time-sensitive external compatibility claim in the "Browser reality" block
(for items like `light-dark()`, `@property` with `inherits: true`, `sign()` in
`calc()`) and after the "Compared to: Tailwind v4" source line; also apply the
same verification-date markers to the other external-claim blocks called out in
the review (the other compatibility/claim sections referenced), so each external
assertion includes an explicit verification date to aid future re-audits.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 17a26163-22b3-4712-9ad3-79ec92444857
📒 Files selected for processing (1)
audits/comparative-audit-2026.md
- Fix typo in F-21 heading: --sf-sf-color-link--visited → --sf-color-link--visited - Add language identifiers (text/css) to all bare fenced code blocks to satisfy markdownlint MD040 - Add (verified: 2026-05-20) markers to time-sensitive browser-compat claims and Appendix C sources table https://claude.ai/code/session_017pNnrbF63T296c3Abo1RCa
Summary
This PR adds a detailed comparative audit of SLASHED against four reference CSS frameworks (Pico CSS v2, Automatic.css v4, Bulma v1, and Tailwind CSS v4), documenting the framework's capabilities, identifying 22 findings across multiple severity levels, and providing a prioritized roadmap for addressing issues before v1 release.
Key Changes
audits/comparative-audit-2026.md): 1,478-line comprehensive analysis covering:Critical Findings Documented
light-dark()and@propertywithinheritsrequire Safari 17.5+/Chrome 123+/Firefox 128+optional/components.cssandoptional/utilities.csscontain only TODO comments, leaving integrators with no button, form, card, or alert components#999hex value violates the framework's own "all values via var()" rule!importantblock unconditionally removes all background colors in print, breaking dark-mode and semantic color preservationslashed.themeslayer declared but never populated; theme rules live inslashed.baseinstead, creating potential specificity inversions--sf-shadow-2xlproduces alpha >1.0 in dark mode without clampingNotable Implementation Details
Roadmap Summary
https://claude.ai/code/session_017pNnrbF63T296c3Abo1RCa
Summary by CodeRabbit