fix(framework): cover-max min-height bug + overflow logical property fallbacks - #338
Conversation
…fallbacks - Replace min-block-size:0 with min-height:0 in .sf-cover--max so the modifier actually overrides the base .sf-cover min-height (different CSS properties don't override each other; browser takes the maximum) - Add overflow-x/overflow-y fallbacks before overflow-inline/overflow-block in .sf-reel, .sf-switcher--no-wrap, pre, .sf-scroll-shadow and .sf-scroll-snap — overflow-inline/block not supported in Safari < 18.2 (December 2024); fallback ensures horizontal/vertical scroll works on older iOS devices still on iOS 17 https://claude.ai/code/session_01Uh4GbFB6UFyGseTGhjW6He
…l-mode - .sf-prose heading gap selector was missing h5 and h6, causing those headings to use the default paragraph spacing instead of the tighter heading gap token - .sf-entrance--* animation-fill-mode overridden to `forwards` inside the @supports (animation-timeline: view()) block so elements are visible before the scroll range is reached (the unconditional `both` would hold opacity:0 from the keyframe's `from` state on elements the user never scrolls past) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uh4GbFB6UFyGseTGhjW6He
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds ChangesSafari Fallbacks and CSS Behavior Fixes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
modifier actually overrides the base .sf-cover min-height (different
CSS properties don't override each other; browser takes the maximum)
in .sf-reel, .sf-switcher--no-wrap, pre, .sf-scroll-shadow and
.sf-scroll-snap — overflow-inline/block not supported in Safari < 18.2
(December 2024); fallback ensures horizontal/vertical scroll works on
older iOS devices still on iOS 17
https://claude.ai/code/session_01Uh4GbFB6UFyGseTGhjW6He
Summary by CodeRabbit
Bug Fixes
Style