Skip to content

fix(framework): cover-max min-height bug + overflow logical property fallbacks - #338

Merged
jackgranatowski merged 2 commits into
mainfrom
claude/cool-meitner-hrk7bn
Jun 17, 2026
Merged

fix(framework): cover-max min-height bug + overflow logical property fallbacks#338
jackgranatowski merged 2 commits into
mainfrom
claude/cool-meitner-hrk7bn

Conversation

@jackgranatowski

@jackgranatowski jackgranatowski commented Jun 17, 2026

Copy link
Copy Markdown
Contributor
  • Replace min-block-size:0 with min-height:0 in .sf-cover--max so the
    modifier actually overrides the base .sf-cover min-height (different
    CSS properties don't override each other; browser takes the maximum)
  • Add overflow-x/overflow-y fallbacks before overflow-inline/overflow-block
    in .sf-reel, .sf-switcher--no-wrap, pre, .sf-scroll-shadow and
    .sf-scroll-snap — overflow-inline/block not supported in Safari < 18.2
    (December 2024); fallback ensures horizontal/vertical scroll works on
    older iOS devices still on iOS 17

https://claude.ai/code/session_01Uh4GbFB6UFyGseTGhjW6He

Summary by CodeRabbit

  • Bug Fixes

    • Fixed overflow behavior for code blocks and layout components across different browsers
    • Improved scroll-driven animation fill behavior for entrance effects
  • Style

    • Extended heading spacing to apply to all heading levels in prose content
    • Enhanced scroll animation and shadow effects with improved overflow handling

claude added 2 commits June 16, 2026 20:15
…fallbacks

- Replace min-block-size:0 with min-height:0 in .sf-cover--max so the
  modifier actually overrides the base .sf-cover min-height (different
  CSS properties don't override each other; browser takes the maximum)
- Add overflow-x/overflow-y fallbacks before overflow-inline/overflow-block
  in .sf-reel, .sf-switcher--no-wrap, pre, .sf-scroll-shadow and
  .sf-scroll-snap — overflow-inline/block not supported in Safari < 18.2
  (December 2024); fallback ensures horizontal/vertical scroll works on
  older iOS devices still on iOS 17

https://claude.ai/code/session_01Uh4GbFB6UFyGseTGhjW6He
…l-mode

- .sf-prose heading gap selector was missing h5 and h6, causing those
  headings to use the default paragraph spacing instead of the tighter
  heading gap token
- .sf-entrance--* animation-fill-mode overridden to `forwards` inside
  the @supports (animation-timeline: view()) block so elements are
  visible before the scroll range is reached (the unconditional `both`
  would hold opacity:0 from the keyframe's `from` state on elements
  the user never scrolls past)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Uh4GbFB6UFyGseTGhjW6He
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 44217511-b2c8-410f-bcb4-b4bf313f2136

📥 Commits

Reviewing files that changed from the base of the PR and between b3daef4 and 61f17b4.

⛔ Files ignored due to path filters (2)
  • dist/badge-essential.json is excluded by !**/dist/**
  • dist/badge-optimal.json is excluded by !**/dist/**
📒 Files selected for processing (4)
  • core/base.css
  • core/layout.css
  • core/macros.css
  • core/motion.css

📝 Walkthrough

Walkthrough

Adds overflow-x: auto and overflow-y: auto as Safari < 18.2 fallbacks alongside existing logical overflow properties across base.css, layout.css, and macros.css. Replaces min-block-size: 0 with min-height: 0 in .sf-cover--max. Expands .sf-prose heading spacing to include h5 and h6. Sets animation-fill-mode: forwards inside the @supports (animation-timeline: view()) block for entrance animations.

Changes

Safari Fallbacks and CSS Behavior Fixes

Layer / File(s) Summary
Safari < 18.2 physical overflow fallbacks
core/base.css, core/layout.css, core/macros.css
Adds overflow-x: auto to pre, .sf-switcher--no-wrap, and .sf-reel; adds overflow-y: auto to .sf-scroll-shadow and .sf-scroll-snap; each inserted before the existing logical overflow-inline/overflow-block property. Replaces min-block-size: 0 with min-height: 0 in .sf-cover--max.
Prose heading selector expansion and animation fill mode fix
core/macros.css, core/motion.css
Expands the .sf-prose heading spacing :is() selector to include h5 and h6. Adds animation-fill-mode: forwards inside the @supports (animation-timeline: view()) block for .sf-entrance--* classes, overriding the both value set in the base rule.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • codeslash-dev/SLASHED#321: Previously converted physical overflow-x/y to logical overflow-inline/block in the same rules (pre, .sf-switcher--no-wrap, .sf-reel, .sf-scroll-shadow, .sf-scroll-snap) that this PR now adds physical fallbacks back alongside.
  • codeslash-dev/SLASHED#155: Modifies the same .sf-cover--max rule whose min-block-size is being replaced with min-height in this PR.
  • codeslash-dev/SLASHED#154: Modifies the same .sf-scroll-shadow rule in core/macros.css that gains an overflow-y: auto Safari fallback in this PR.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(framework): cover-max min-height bug + overflow logical property fallbacks' directly reflects the main changes: fixing the cover-max min-height issue and adding overflow property fallbacks for Safari compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/cool-meitner-hrk7bn

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jackgranatowski
jackgranatowski merged commit aac8e1a into main Jun 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants