Skip to content

fix(configurator): refresh probe host in ShadeRamp so swatches resolve against live cascade - #388

Merged
jackgranatowski merged 1 commit into
mainfrom
codex/dostosuj-pr381-do-frameworku
Jun 23, 2026
Merged

fix(configurator): refresh probe host in ShadeRamp so swatches resolve against live cascade#388
jackgranatowski merged 1 commit into
mainfrom
codex/dostosuj-pr381-do-frameworku

Conversation

@jackgranatowski

Copy link
Copy Markdown
Contributor

Motivation

  • The PR381 color ramp needs to resolve derived/registered framework tokens against the same live cascade the rest of the configurator uses, so the ShadeRamp must refresh the shared probe host with current overrides and preview theme before measuring swatches.

Description

  • Import and call setProbeContext({ overrides, theme: ui.previewTheme }) from configurator/src/components/ShadeRamp.svelte before calling measureBackground() so the probe host carries the live framework declarations.
  • Keep existing measureBackground() logic and populate resolved as before so visual behaviour is unchanged in browsers.
  • Add component tests in configurator/tests-components/shade-ramp.test.js that assert the ramp renders six rows × seven swatches and that the probe-host style block is refreshed for overrides and the dark preview theme.
  • Commit message: fix(configurator): align shade ramp probe with live framework cascade.

Testing

  • Ran configurator component tests with npm run test:components and all component specs passed (5 test files, 24 tests passed).
  • Ran Svelte type/check and build with npm run check && npm run build inside configurator which completed successfully (Svelte warnings remained but no errors).
  • Verifications were performed locally by building the framework/docs pipeline (npm run build) and syncing the configurator data during the run.

Codex Task

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jackgranatowski, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 28 minutes and 50 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d23f90c2-86b7-4f2c-9b7d-b10dd31f30ab

📥 Commits

Reviewing files that changed from the base of the PR and between 162787a and c4cedbc.

📒 Files selected for processing (2)
  • configurator/src/components/ShadeRamp.svelte
  • configurator/tests-components/shade-ramp.test.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/dostosuj-pr381-do-frameworku

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jackgranatowski

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant