fix(configurator): stop mobile domain panel overflowing past the icon rail - #464
Conversation
… rail The domain panel sat in the same flex row as the icon nav rail but used w-full (100% of the whole row, not the space remaining after the rail) combined with shrink-0 (refusing to shrink to fit). With the rail's ~56px plus the panel's full row width, the row demanded more space than the viewport had, silently clipping content on the right with no scrollbar since the app root uses overflow-hidden. Switch to flex-1 min-w-0 on mobile so the panel fills whatever space is actually left after the rail and can shrink to fit; md:flex-none keeps the desktop behavior (fixed 360px, no growing/shrinking) unchanged. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQXr34nocCi1jrGcp5TPVm
|
Warning Review limit reached
Next review available in: 6 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoFix mobile domain panel overflow next to icon rail
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Pulls in the App.svelte fix from codeslash-dev/SLASHED#464: the domain panel used w-full + shrink-0 in the same flex row as the icon nav rail, so it demanded 100% of the whole row's width instead of just the space left after the rail — overflowing the viewport by the rail's width with no scrollbar. Now flex-1 min-w-0 on mobile so it fills only what's actually left; desktop keeps its fixed 360px width via md:flex-none. Same root cause affects the WP admin Tokens page on mobile, independent of the earlier embedded-sizing fix (#122). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQXr34nocCi1jrGcp5TPVm
It sat at the very bottom of the screen, below the domain panel and above the status bar — awkward to reach and easy to miss. Move it directly under the header instead, so it's immediately visible and reachable without scrolling to the bottom on tall phones. Same buttons/state/handlers, just relocated. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQXr34nocCi1jrGcp5TPVm
Pulls in the App.svelte change from codeslash-dev/SLASHED#464: the mobile Controls/Preview toggle moved from the very bottom of the screen (below the domain panel, above the status bar) to directly under the header, so it's reachable without scrolling on tall phones. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQXr34nocCi1jrGcp5TPVm
Summary
App.svelte) sits in the same flex row as the icon nav rail. On mobile it usedw-full(100% of the whole row, not the space remaining after the rail) combined withshrink-0(refusing to shrink). With the rail's ~56px plus the panel's full-row width, the row demanded more space than the viewport had — silently clipped on the right with no scrollbar, since the app root usesoverflow-hidden.flex-1 min-w-0on mobile so the panel fills whatever space is actually left after the rail and can shrink to fit;md:flex-nonepreserves the desktop behavior (fixed 360px) unchanged.Test plan
scrollWidth(468px) exceededclientWidth(412px) by exactly the rail's width, with 0 elements overflowing at document level (silently clipped, not scrolled) — matching the reported symptom.scrollWidth === clientWidth, 0 overflowing elements, and a full-page screenshot confirms all content (including the previously-cut-off "Inverse" swatch and wrapped paragraph text) now fits with proper right-side padding.npx svelte-check— 0 errors.npm run build— builds cleanly.npm run check:version— in sync.🤖 Generated with Claude Code
https://claude.ai/code/session_01SQXr34nocCi1jrGcp5TPVm
Generated by Claude Code