docs: add user-manual with end-user color system guide - #467
Conversation
Starts a new end-user documentation tree (distinct from the contributor-facing docs/) with a task-oriented guide to the color system: source tokens, light/dark, shade ramps, status colors, and text-on-color contrast, verified against core/tokens.css and core/themes.css. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UqerHc5MPryMBp62TVS1Ds
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoAdd end-user user-manual with color system guide
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
6 rules 1. Overbright base example
|
| :root { | ||
| --sf-color-primary-source-light: oklch(0.55 0.18 280); | ||
| --sf-color-secondary-source-light: oklch(0.30 0.04 280); | ||
| --sf-color-tertiary-source-light: oklch(0.62 0.15 200); | ||
| --sf-color-action-source-light: oklch(0.62 0.16 150); | ||
| --sf-color-neutral-source-light: oklch(0.45 0.01 280); | ||
| --sf-color-base-source-light: oklch(0.99 0.004 280); | ||
| } |
There was a problem hiding this comment.
1. Overbright base example 🐞 Bug ≡ Correctness
user-manual/colors.md suggests setting --sf-color-base-source-light to oklch(0.99 …), which can cause derived surface levels (bg/raised) to clamp toward white and become visually indistinguishable in light mode.
Agent Prompt
## Issue description
The rebranding example sets `--sf-color-base-source-light` to `oklch(0.99 …)`, but the framework’s own guidance warns that near-1.0 base values can flatten the derived surface offsets, making `bg/inset/raised` less distinct.
## Issue Context
This is an end-user manual example and will be copy-pasted; it should align with the framework’s recommended ranges.
## Fix Focus Areas
- user-manual/colors.md[34-46]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| SLASHED's entire color system is generated from **10 source colors**. You set | ||
| those, and everything else — dark mode, hover states, tints, borders, text | ||
| contrast — is derived automatically. You should never need to hand-pick a hex | ||
| value for a hover state or a dark-mode variant. | ||
|
|
||
| > Source of truth: `core/tokens.css` and `core/themes.css`. If anything here | ||
| > ever looks out of date, those files win. | ||
|
|
||
| ## The 10 source colors | ||
|
|
||
| | Token | Role | Use it for | | ||
| |---|---|---| | ||
| | `--sf-color-primary` | Brand identity | Hero sections, brand-forward surfaces, marketing CTAs | | ||
| | `--sf-color-secondary` | Supporting brand color (darker, low-chroma by default) | Secondary brand surfaces, footers, dark bands | | ||
| | `--sf-color-tertiary` | Accent brand color | Tags, chart accents, decorative flourishes | | ||
| | `--sf-color-action` | **Default interactive color** | Buttons, links, focus rings, form controls — anything clickable | | ||
| | `--sf-color-neutral` | Desaturated grey | Feeds text, borders, scrollbars — not used directly very often | | ||
| | `--sf-color-base` | Page surface color | Feeds backgrounds (`bg`, `inset`, `raised`) — not used directly very often | | ||
| | `--sf-color-success` | Positive status | Confirmations, success alerts/badges | | ||
| | `--sf-color-warning` | Caution status | Non-blocking warnings | | ||
| | `--sf-color-info` | Neutral/informational status | Informational banners/badges | | ||
| | `--sf-color-danger` | Negative status | Errors, validation failures, destructive actions | |
There was a problem hiding this comment.
2. Source token naming confusion 🐞 Bug ≡ Correctness
The “10 source colors” section says “You set those” but lists resolved tokens like --sf-color-primary/--sf-color-danger, while the actual user-settable inputs are the -source-light/-source-dark tokens; this can mislead users into overriding computed tokens and losing automatic dark-mode derivation.
Agent Prompt
## Issue description
The manual calls `--sf-color-primary`/etc “source colors” and implies users set them, but the framework’s theming entry points are the `--sf-color-*-source-light` (and optional `-source-dark`) tokens; `--sf-color-*` are derived/resolved outputs.
## Issue Context
The doc later shows `-source-light` overrides, so the main fix is to clarify terminology and/or adjust the table to prevent incorrect theming guidance.
## Fix Focus Areas
- user-manual/colors.md[3-25]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Starts a new end-user documentation tree (distinct from the
contributor-facing docs/) with a task-oriented guide to the color
system: source tokens, light/dark, shade ramps, status colors, and
text-on-color contrast, verified against core/tokens.css and
core/themes.css.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01UqerHc5MPryMBp62TVS1Ds