feat: draft framework-CSS landing page for review - #504
Conversation
|
Warning Review limit reached
Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoDraft GitHub Pages landing page styled by SLASHED CDN bundle (kept out of build)
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
11 rules 1.
|
|
Re: #2 Mutable external CSS dependency (from the code review comment) — declining this one, keeping the CDN link as-is. This was an explicit, deliberate choice, not an oversight: the page's own install instructions tell visitors to pull the framework from Pinning to Generated by Claude Code |
An unexpected stored value (corrupted, or from a future version with different states) would be applied directly to data-theme, which the framework's selectors don't recognize, leaving the page in a mismatched state with a stale button label. Validate against the known states and fall back to 'auto' otherwise. Verified with Playwright: seeding localStorage with a garbage value before load now normalizes to auto (data-theme absent, label "Auto"), and the toggle still cycles correctly afterward. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019y4H17xqMWoEgvxv3BRM98
a834622 to
87e3e0a
Compare
|
Closing this out: the only content this PR actually contributed beyond Generated by Claude Code |
Summary
copy-wip/github-pages-index.htmlfor review before promotion toindex.mdat repo root.slashed.optimal.css, loaded from the jsDelivrdistCDN — the same URL the page's own install instructions tell visitors to use. Layout usessf-section/sf-container/sf-stack/sf-cluster/sf-bento; macros includesf-prose,sf-surface,sf-text-gradient,sf-divider; scroll-drivensf-entranceanimations on feature cards. All page-specific CSS lives in the reservedslashed.overrideslayer and composes framework tokens exclusively — no raw colors, sizes, or fonts.S/L/A/S/H/E/Dinto its manifesto word on hover. The interaction is geometry-stable: each word expands to a measured width and the row counter-shifts by exactly half that width, so the hovered letter never drifts onto a neighbor mid-animation. Gated to(any-hover: hover), respectsprefers-reduced-motion, has a 120ms sweep-guard delay.--sf-color-primary50→950 ramp, side-by-sidedata-themepanels, the real fluid type scale.data-theme="dark"band on an otherwise light page, demonstrating section-scoped theming as a live example. Its code blocks pin to theme-safe tokens and wrap instead of horizontally scrolling (a related framework bug where code-token colors don't follow scopeddata-themeis filed as Code-block color tokens don't follow section-scopeddata-theme#496).copy-wip/is excluded from the Jekyll build (_config.yml) so the draft isn't published while under review.Context
Split out of #492, which began as a README/index copy fix and grew into this full redesign plus several review rounds of bugfixes (localStorage guard, hover-drift fix, mobile band hardening, CDN load switch). See #[readme PR] for the README-only half.
Test plan
index.mdat repo root and deletecopy-wip/github-pages-index.html🤖 Generated with Claude Code
Generated by Claude Code