fix: attach all dist bundles to releases + backfill CHANGELOG - #72
Conversation
- release.yml: attach all 30 dist files (readable + minified + source maps for all 5 bundle tiers) instead of only slashed.essential.css - CHANGELOG.md: add missing [0.2.11] and [0.2.12] sections that were skipped because releases were created manually via GitHub UI instead of release-it - package.json: bump version to 0.2.12 to match the published release tag Co-authored-by: Jack Granatowski <contact@codeslash.net>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (11)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR prepares the v0.2.12 release by updating the package version to 0.2.12, documenting changelog entries for versions 0.2.11 and 0.2.12 covering Bricks Builder integration and infrastructure updates, and expanding the GitHub Release workflow to distribute additional CSS build artifacts including minified and flat variants with source maps. ChangesRelease Configuration and Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 3: package.json version was bumped to "0.2.12" but package-lock.json
still lists "0.2.10" (top-level version and packages[""].version), causing npm
warnings; regenerate the lockfile by running npm install --package-lock-only (or
npm ci then npm install) to update package-lock.json so its top-level version
and packages[""].version match package.json, then commit the updated
package-lock.json.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: fcf988c3-38d3-492d-ba56-387e72ce6083
📒 Files selected for processing (3)
.github/workflows/release.ymlCHANGELOG.mdpackage.json
This pull request was created by @kiro-agent on behalf of @jackgranatowski 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro autonomous agent
Summary
Fixes two issues with the release workflow:
1. Only one CSS file attached to releases
release.ymlhadfiles: dist/slashed.essential.csshardcoded. Now attaches all 30 dist files:.css), minified (.min.css), source map (.min.css.map)2. CHANGELOG empty for recent releases
Releases v0.2.11 and v0.2.12 were created manually via GitHub UI instead of
npm run release, sorelease-itnever ran and CHANGELOG was never updated. This PR backfills:--sf-contrast-thresholdwiring (PR docs: fix 4 factual inaccuracies in comparative-gap-audit.md #68)Also bumps
package.jsonversion to0.2.12to match the published tag.For future releases
Use
npm run releasefrom the command line (not GitHub UI "Create release"). This ensures:release.ymlworkflow then picks up the tag, extracts notes from CHANGELOG, and publishes the GitHub Release with all assets attachedSummary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores