docs(audit): pre-freeze API audit for v0.3.0 - #96
Closed
kiro-agent[bot] wants to merge 4 commits into
Closed
Conversation
Full audit of public API surface covering: - Token declaration vs usage consistency - Naming conventions and scale uniformity - Class coverage and documentation sync - Cascade layer correctness - Bundle integrity - Documentation freshness - API freeze contract completeness Findings: 2 breaking (A-1, G-1), 10 hygiene issues. Co-authored-by: Jack Granatowski <contact@codeslash.net>
jackgranatowski
marked this pull request as draft
May 26, 2026 07:57
…ove dead audit refs - Add --sf-animation-spin, --sf-animation-shimmer presets - Add --sf-state-pending-opacity: 0.7 - Add --sf-ratio-4-3, --sf-ratio-3-2; deprecate --sf-ratio-photo - Add brand hover tokens (primary, secondary, tertiary, action, neutral) - Fix --sf-animation-blink to use calc(1s * var(--sf-motion-scale)) - Add @Property registrations: --sf-is-active, --sf-is-current, --sf-is-pressed, --sf-is-open - Update header comment: alias chain now describes 3 hops - Replace audit section D9 refs in tokens.css, motion.css - Remove dead audit reference in print.css - Add --sf-alternate-gap, --sf-alternate-inner-gap to tokens.layout.css - Update token-api snapshot with 16 new tokens
…eader-height fallbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created by @kiro-agent on behalf of @jackgranatowski 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro autonomous agent
Summary
Full public API audit of SLASHED v0.3.0 before the token-API freeze. The audit reads every source file (
core/*.css, activeoptional/*.css, alldocs/*.md,demo.html, build config, scripts) and checks 25 items across 7 categories.Key findings
🔴 Breaking (must fix before freeze)
.sf-frame--4-3renders 3:2 (token--sf-ratio-photo = 3/2);.sf-frame--3-2hardcodes same value. Class name is misleading — two classes produce identical output.tokens.cssheader covers only ~30% of 608 tokens. Without precise boundary, SemVer freeze is unenforceable.🟠 API hygiene (10 issues)
--sf-header-height3.5rem vs declared 8rem).sf-icon--boxedexcluded from coverage, absent from demodocs/macros.md--sf-is-active/current/pressed/open)✅ Solid
Layers, bundle topology, alias chains, naming prefix, keyframes,
!importantdiscipline, palette/theme-example consistency, tokens.md generation pipeline.What was tested
demo.html(Python script matching test logic)bundle.config.jsonpackage.jsonexports vsdist/contentsFiles changed
audits/audit-a.md(new, 309 lines)