fix: apply the Snippets List Order setting again (3.10.1)

[TallblokeUK]

Targeting core for 3.10.1. Same change as #465, which targets core-beta — whichever suits the release, the other can be closed.

The bug

Reported from support: Settings → Snippets List Order has no effect. Whichever of its five options you pick, the All Snippets table opens in the same order.

Reproduced on two clean installs — WP 7.0.4 / PHP 8.2.33 and WP 7.1 / PHP 8.3.33. Name (Z-A) should invert the list; nothing moved on either.

Cause

The setting is still defined and still rendered, but nothing reads it. Its only two references in 3.10.0:

Settings_Fields.php:91    'list_order' => 'priority-asc',   ← default value
Settings_Fields.php:191   'list_order' => [ … ],            ← the field in Settings

Until 3.10 the list table applied it directly:

// 3.9.2 — class-list-table.php:1311
$order = Settings\get_setting( 'general', 'list_order' );

Sorting moved to the column headings during the admin rewrite. The consumer went with the old table; the setting stayed in the UI, reading nothing.

Approach

The headings are the mechanism now, so this doesn't restore a parallel ordering system. It maps the setting onto the table's opening sort — which is what the setting describes itself as: "Default way to order snippets on the All Snippets admin menu."

• list_order is localized alongside the other manage data
• mapped to a column id and direction (priority/name/date, asc/desc)
• passed to ListTable as a new optional initialSort

Clicking a heading overrides it for the rest of the visit, exactly as it overrides any other starting order. The initialSort prop is optional, so no other ListTable consumer changes behaviour.

On removing it instead: that was the alternative, and it's defensible given headings supersede it. I didn't, because it's a visible feature removal for anyone who has it configured, and the value is carried in saved settings either way — honouring it costs less than taking it away. Easy to flip if you'd rather retire the setting.

Verification

Against a reproduction of the reported environment (WP 7.0.4, PHP 8.2.33, 3.10.0, 190 snippets):

list_order	before	after
priority-asc	Repro 001, 002, 003, 004	Repro 002, 003, 004, 005
name-desc	Repro 001, 002, 003, 004	Repro 190, 189, 188, 187

An e2e test covers it and fails without the change. Full suite: 90 Playwright, 157 PHPUnit, 0 failures; lint:js and lint:styles clean.

Manage_Menu_Assets_Test pins the localized key list, so it gains listOrder.

Note

No changelog entry, consistent with #461, #462 and #463.

Fixes #474

[code-snippets-bot]

Download and install

📦 code-snippets.3.10.0.zip