Enforce passive update check deadline#55
Merged
Conversation
…dline in test The outer run_passive_check deadline equals the inner HTTP timeout, so a hung network could cancel passive_version_check before the timestamp write, defeating the retry-storm guard and re-paying the full deadline every run. Write the timestamp before the attempt so cancellation cannot skip it, and strengthen the paused-clock test to assert the deadline's exact value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-utilas a dev-only feature for deterministic deadline tests.Verification
RUSTFLAGS="-D warnings" cargo test— passescargo test --lib update— passescargo clippy --all-targets -- -D warnings— passescargo fmt --check— passesCloses #36