Require chart captions and a geometry sanity check before shipping - #35
Merged
Conversation
Real skill output included a scatter-plot-plus-trend-line card with axis labels but no heading, floating next to a stat list with no stated connection between them — and a trend line that didn't appear to clearly anchor to the plotted point range. Every other card-shaped component in the show-don't-tell table already requires a caption; a chart, which needs one more than most, was the one exception. - references/component-patterns.md: added a note directly under the show-don't-tell table stating a chart is not exempt from its own requirement — every chart/graph card needs a one-line heading or caption, and must be tied explicitly (visually or in copy) to any related stats or claims sitting next to it rather than floating unexplained. - references/anti-slop-checklist.md: new checklist item next to the existing SVG-validation item, since `scripts/validate_assets.py` only confirms well-formed XML, not whether the data marks mean anything. Requires an actual look before shipping: trend lines span the real plotted range, bar heights reflect labeled values, etc. Closes #29 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Real skill output included a scatter-plot-plus-trend-line card with axis labels but no heading, floating next to a stat list with no stated connection between them — plus a trend line that didn't clearly anchor to the plotted point range. Every other card-shaped component in the show-don't-tell table already requires a caption; a chart, which needs one more than most, was the one exception.
references/component-patterns.md— a note directly under the show-don't-tell table: a chart is not exempt from its own requirement. Every chart/graph card needs a one-line heading or caption, and must be tied explicitly to any related stats/claims next to it rather than floating unexplained.references/anti-slop-checklist.md— new checklist item next to the existing SVG-validation item, sincescripts/validate_assets.pyonly confirms well-formed XML, not whether the data marks mean anything. Requires an actual look before shipping: trend lines span the real plotted range, bar heights reflect labeled values, etc.Closes #29
Test plan