Skip to content

Add css to package#101

Merged
groovecoder merged 9 commits intomasterfrom
add-css-to-package
Jun 29, 2016
Merged

Add css to package#101
groovecoder merged 9 commits intomasterfrom
add-css-to-package

Conversation

@jdungan
Copy link
Copy Markdown
Member

@jdungan jdungan commented Jun 26, 2016

No description provided.

@jdungan jdungan force-pushed the add-css-to-package branch from 247dfec to e0ee017 Compare June 26, 2016 18:10
Comment thread src/chrome/manifest_additions.json Outdated
@@ -10,8 +10,5 @@
"16": "img/icon16.png",
"48": "img/icon48.png"
},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This icons property needs to go into the master manifest.json - not just chrome additions.

codesy-addon-icon

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icons now in manifest.json done by 127bbc4

@jdungan
Copy link
Copy Markdown
Member Author

jdungan commented Jun 28, 2016

This is needed to support codesy/codesy#371

@groovecoder
Copy link
Copy Markdown
Member

This works; though gulp dev is sometimes flaky rebuilding the chrome directory? Filing a separate issue.

@groovecoder groovecoder merged commit ef6a0df into master Jun 29, 2016
@groovecoder groovecoder deleted the add-css-to-package branch June 29, 2016 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants