Point the profile metadata comment at the decision, not a follow-up - #145
Merged
Conversation
The comment landed in #143 saying that fixing the generic profile unfurl "means giving this route an image of its own, which is the per-profile card in #142" — written when that was still expected work. It is not: #144 considered it and was closed, because baking a revocable Verified badge into a cached image turns staleness from cosmetic into a correctness problem, and a profile card would ship that before the invalidation mechanism in #117 exists. So the comment now points at #144 as the record of the decision rather than implying a follow-up nobody is going to pick up. Shorter too — the part worth keeping is why an `openGraph` block here would take the share card with it, which is the mistake the next person will otherwise make.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only. No behaviour change.
src/app/p/[handle]/page.tsxpicked up a comment in #143 explaining whygenerateMetadatadeliberately declares noopenGraph. It ended by saying the proper fix "means giving this route an image of its own, which is the per-profile card in #142" — true when it was written, and no longer.#144 cut that ticket and then closed it. A per-profile card bakes the Verified badge into an image, and
verifiedis Bluehex-owned and revocable: today a stale card is a generic card and harmless, but with the badge baked in a stale card is a pulled badge still being served out of Slack's and LinkedIn's caches. That makes #117 a correctness dependency rather than a scheduling one, and it is not a trade worth making for copy on a card while the directory is this small.So the comment points at #144 as the record instead of implying work nobody intends to do. It is also shorter: the part worth keeping is the trap — naming
openGraphon this route replaces every field the root set and takes the share card with it, because the root never declaresimagesand the file convention injects them. That is the mistake the next person makes, and it was made and reverted during #143's review.pnpm lintclean,pnpm test305 passed. Nothing else touched.