Refactoring SCSS - Modals #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for donut-frontend-r ready! Built with commit 6cea547 |
vaibhavdaren
approved these changes
May 11, 2020
AuraOfDivinity
added a commit
to AuraOfDivinity/social-platform-donut-frontend
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on refactoring the SCSS used in Modals throughout the project,
1.) All the styling related files modals are now on a separate set of folders and are restructured according to the 7-1 architecture. (https://www.learnhowtoprogram.com/user-interfaces/building-layouts-preprocessors/7-1-sass-architecture).
Renamed the class names of almost all of the classes to meet the Block Element Modifier guidelines. The class names are a lot more descriptive now thanks to this. (http://getbem.com/introduction/)
All the modals throughout the project, now use a single set of predefined SCSS classes.
I have also used SCSS variables wherever possible. Changing one of these variables defined in the _variables.scss would now update all the modals throughout the project.