-
Notifications
You must be signed in to change notification settings - Fork 219
Proposal dashboard page implementation outline #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal dashboard page implementation outline #474
Conversation
|
Deploy preview for donut-frontend-r ready! Built with commit 73abdd8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AuraOfDivinity Do you have the latest code because in my previous PR(merged #470 ) the inconsistencies which are fixed are still there in your PR. (Check the event section of my PR #470 deployed link: https://deploy-preview-470--donut-frontend-r.netlify.app/dashboard)
Also, check the deployment of your PR because it's breaking the navigation too. Please check it once (Your PR deployed link: https://deploy-preview-474--donut-frontend-r.netlify.app/)
And also the design which you have attached is not there on the dashboard implementation of the deployed version, check that too.
Check it once.
The code looks fine.
…de (codeuino#470) * fixed some client side issues and integrated backend * Make build.sh executable Co-authored-by: Devesh Verma <deveshverma619@gmail.com>
|
@Rupeshiya Thanks for mentioning. I forgot to pull the latest changes. As for the page, you can access it through the "/proposal" route. |
|
Hey, @AuraOfDivinity proposal part looks fine, just wrap the proposal details and proposal option in a single row so that there would not be any alignment issue, also justify-content of the proposal details paragraph as there is some alignment issue in paragraph details part. Also, it's still breaking the dashboard navigation. |
|
@AuraOfDivinity @vaibhavdaren After merging this PR, some of the changes which I have done, is not looking good. Please check once. |
|
@vaibhavdaren I will make a PR with the solution me and @Rupeshiya figured out to fix this. |

Partially fixes #473
This PR implements the proposal dashboard(user view) page according to the designs mentioned at figma.