Skip to content

Conversation

@AuraOfDivinity
Copy link
Collaborator

Partially fixes #473

This PR implements the proposal dashboard(user view) page according to the designs mentioned at figma.

page1

@netlify
Copy link

netlify bot commented May 15, 2020

Deploy preview for donut-frontend-r ready!

Built with commit 73abdd8

https://deploy-preview-474--donut-frontend-r.netlify.app

@vaibhavdaren vaibhavdaren requested a review from Rupeshiya May 15, 2020 17:09
Copy link
Member

@Rupeshiya Rupeshiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AuraOfDivinity Do you have the latest code because in my previous PR(merged #470 ) the inconsistencies which are fixed are still there in your PR. (Check the event section of my PR #470 deployed link: https://deploy-preview-470--donut-frontend-r.netlify.app/dashboard)
Also, check the deployment of your PR because it's breaking the navigation too. Please check it once (Your PR deployed link: https://deploy-preview-474--donut-frontend-r.netlify.app/)

And also the design which you have attached is not there on the dashboard implementation of the deployed version, check that too.
Check it once.
The code looks fine.

AuraOfDivinity and others added 2 commits May 15, 2020 23:15
…de (codeuino#470)

* fixed some client side issues and integrated backend

* Make build.sh executable

Co-authored-by: Devesh Verma <deveshverma619@gmail.com>
@AuraOfDivinity
Copy link
Collaborator Author

@Rupeshiya Thanks for mentioning. I forgot to pull the latest changes. As for the page, you can access it through the "/proposal" route.

@Rupeshiya
Copy link
Member

Rupeshiya commented May 15, 2020

Hey, @AuraOfDivinity proposal part looks fine, just wrap the proposal details and proposal option in a single row so that there would not be any alignment issue, also justify-content of the proposal details paragraph as there is some alignment issue in paragraph details part.

Also, it's still breaking the dashboard navigation.
Just check that once.
Great use of flexbox, awesome. 👍

@vaibhavdaren vaibhavdaren changed the title GSoC frontend - Proposal dashboard page implementation Proposal dashboard page implementation outline May 31, 2020
@vaibhavdaren vaibhavdaren merged commit fb20260 into codeuino:development May 31, 2020
@Rupeshiya
Copy link
Member

Rupeshiya commented Jun 1, 2020

@AuraOfDivinity @vaibhavdaren After merging this PR, some of the changes which I have done, is not looking good.
@AuraOfDivinity Can you please run locally and check it seems that two-column in the dashboard is bigger than what I had done also the write post section

Please check once.

@Rupeshiya
Copy link
Member

Check the dashboard column.
image

@AuraOfDivinity
Copy link
Collaborator Author

@vaibhavdaren I will make a PR with the solution me and @Rupeshiya figured out to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants