Skip to content

Inconsistency fix and backend integration, worked on events client side #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 13, 2020
Merged

Inconsistency fix and backend integration, worked on events client side #470

merged 6 commits into from
May 13, 2020

Conversation

@Rupeshiya
Copy link
Member

@Rupeshiya Rupeshiya commented May 13, 2020

PR Includes fixes for the following:

  • Overflow in the horizontal direction in settings page - (done)
  • Breaking the left sidebar on Lottie animation loading (Pending)
  • Overflow in the horizontal direction in projects page - (done)
  • Jitsi meet button is looking odd on the left sidebar - (done)
  • Settings icon and logout icons are floating, make it sticky to the bottom- (done )
  • Add edit, delete icons on events sections popup - (done)
  • Added popup to edit the event - (done)
  • Added popup to confirm the event deletion - (done)
  • Fixed alignment inconsistencies in event details descriptions - (done)
  • Event backend integration- (done)

@netlify
Copy link

netlify bot commented May 13, 2020 •
edited
Loading

Deploy preview for donut-frontend-r ready!

Built with commit 01dcaf5

https://deploy-preview-470--donut-frontend-r.netlify.app

@Rupeshiya
Copy link
Member Author

Rupeshiya commented May 13, 2020 •
edited
Loading

@vaibhavdaren Please review.
Also, I tried to squash the commits but the problem is that when I am trying to interactive rebase and squash then again build.sh becomes not executable.
Check this is the exact problem https://stackoverflow.com/questions/42154912/permission-denied-for-build-sh-file also please check the comments of 1st answer. (Same issue)

I think the issue is due to my system so It would be better if we can configure somehow to make this test cases platform-independent

@vaibhavdaren vaibhavdaren merged commit 4a1d1a0 into codeuino:development May 13, 2020
@Rupeshiya Rupeshiya mentioned this pull request May 15, 2020
Merged
AuraOfDivinity pushed a commit to AuraOfDivinity/social-platform-donut-frontend that referenced this pull request May 15, 2020
@Rupeshiya @devesh-verma @AuraOfDivinity
Inconsistency fix and backend integration, worked on events client si…
2c0c54a 
…de (codeuino#470)

* fixed some client side issues and integrated backend

* Make build.sh executable

Co-authored-by: Devesh Verma <deveshverma619@gmail.com>
vaibhavdaren pushed a commit that referenced this pull request May 31, 2020
@AuraOfDivinity
GSoC frontend - Proposal dashboard page implementation (#474)
fb20260 
* GSoC frontend - Proposal dashboard page implementation

* refactoring components-modals (#468)

* Inconsistency fix and backend integration, worked on events client side (#470)

* fixed some client side issues and integrated backend

* Make build.sh executable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rupeshiya @vaibhavdaren @devesh-verma