Skip to content

Validate combined settings flow (codex) - #2318

Merged
numnx merged 1 commit into
feature/CODUX-139-settings-mcp-and-custom-containerfrom
task/feature-codux-139-settings-mcp-and-custom-contai-t05-codex-mr91zacw
Jul 6, 2026
Merged

Validate combined settings flow (codex)#2318
numnx merged 1 commit into
feature/CODUX-139-settings-mcp-and-custom-containerfrom
task/feature-codux-139-settings-mcp-and-custom-contai-t05-codex-mr91zacw

Conversation

@numnx

@numnx numnx commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

🧩 Task: Validate combined settings flow

Automated task PR opened by Code UX for T05.

📋 Summary

Sprint: Sprint 139 · Settings mcp and & custom container · Task: T05

Improve Settings so operators can configure HTTP MCP servers with clear guidance and choose a custom container setup script through a file-picker field.

📝 Full Task Prompt
## Objective
Add a narrow integration test ensuring the MCP guidance and custom container setup-script picker coexist on the Settings page without breaking category navigation, dirty-state handling, or save drafts.

## Scope
- `tests/dashboard/v2/settings-page-data.test.tsx` or `tests/dashboard/settings-page.test.tsx`, whichever already mounts the full settings page with category navigation
- `dashboard/src/v2/lib/project-api.ts` mocks for the `fetchLocalFiles` helper from T01
- No production files unless a test exposes a real integration defect

## Implementation Requirements
1. Mount the Settings page or page-state harness with default dashboard settings that include `cliWorkflow.containerSetupScriptPath`, `customMcpServers`, and `mcpTools`.
2. Navigate to General or the category containing Docker Runtime, open the setup script picker, select a mocked file, and assert the settings draft becomes dirty with the selected path.
3. Navigate to MCP, assert the HTTP MCP setup guidance added by T03 is visible, create or inspect an HTTP custom server, and assert the draft state from the setup script field was not lost during category navigation.
4. Keep mocks local to the test and avoid relying on a real server, filesystem, Docker, or browser preview runtime.

## Constraints
- This task depends on T02 and T03 because it verifies their combined dashboard behavior.
- Do not duplicate all focused tests from T02 or T03; cover only the cross-panel regression.
- Do not change API routes, settings schema, or runtime behavior unless the integration test reveals an actual bug.
- Keep the test deterministic and avoid real project/customer names in fixtures.

## Verification
- Run the focused settings page test file selected for this task with `pnpm exec vitest run <test-file>`.
- Run `pnpm run test:dashboard`.
- Run `pnpm run lint`.
- Success means category navigation preserves the setup-script draft while MCP HTTP guidance and custom-server controls remain available.

✅ QA Review

⏳ QA review runs after this PR is opened. Check the task card in the dashboard for the outcome once it lands.

🤖 Model & Provider

Provider Codex CLI
Model gpt-5.5

⏱️ Timing

Started 2026-07-06 10:05:36 UTC
Finished 2026-07-06 10:10:08 UTC
Duration 4m 32s

📊 Token Usage

Metric Value
Input tokens 112,942
Cached input tokens 1,956,736
Output tokens 7,644
Total tokens 2,077,322
Invocations 2
Tool calls 40
Active time 4m 23s

Included usage estimate (subscription/local login): $1.77

🌿 Branch Info

Base: feature/CODUX-139-settings-mcp-and-custom-container
Head: task/feature-codux-139-settings-mcp-and-custom-contai-t05-codex-mr91zacw


🤖 Generated by Code UX

@numnx
numnx merged commit 1c52266 into feature/CODUX-139-settings-mcp-and-custom-container Jul 6, 2026
4 checks passed
@numnx
numnx deleted the task/feature-codux-139-settings-mcp-and-custom-contai-t05-codex-mr91zacw branch July 6, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant