fix: harden orchestration restart recovery - #2328
Merged
Merged
Conversation
…toring-hardening # Conflicts: # docs/operations/runbook.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens orchestration recovery across app restarts and restart-edge cases.
Root Cause
Restart recovery had several independent paths for sprint runs, dispatches, provider invocations, QA rows, leases, Docker containers, and sprint projection rows. Those paths could disagree after a restart, especially around paused runs, interrupted local invocations, preserved Docker volumes, and virtual merge-conflict repair.
Validation
pnpm run typecheckpnpm vitest run tests/backend/services/runtime-startup-recovery-service.test.ts tests/backend/infrastructure/providers/cli/workspace-artifact-service.test.ts tests/backend/repositories/settings-repository.test.tspnpm vitest run tests/backend/services/virtual-worker-service.test.tspnpm run buildhttp://127.0.0.1:4444/readyafter stress.Risk / Rollback
Risk is concentrated in startup recovery and virtual-worker merge-conflict handling. Rollback is reverting this PR; existing persisted sprint/task state remains compatible because the new restart policy settings default to
continueand sanitize unknown values back to defaults.